[ALL] Avoiding duplication of work between GitHub PRs and JIRA

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[ALL] Avoiding duplication of work between GitHub PRs and JIRA

garydgregory
Hi All:

I'll start with this example from Commons VFS and its changes.xml:

      <action issue="VFS-692" dev="ggregory" type="update" due-to="Gary
Gregory">
        Update Apache Commons Collections from 4.2 to 4.3.
      </action>

      <action                 dev="ggregory" type="update" due-to="Boris
Petrov, Gary Gregory">
        Add support for customizing FTP transfer aborted status codes.
GitHub PR #51.
      </action>

The first entry uses a JIRA reference as usual.

In the second entry, I applied a PR from GitHub but I did not create a
matching JIRA issue. The fact that we have a change is still tracked in
changes.xml. The site report will not have a URL to JIRA.

Question: Can we make the changes plugin generate a link to GitHub for a PR?

Gary
Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Avoiding duplication of work between GitHub PRs and JIRA

sebb-2-2
On Wed, 6 Mar 2019 at 13:54, Gary Gregory <[hidden email]> wrote:

>
> Hi All:
>
> I'll start with this example from Commons VFS and its changes.xml:
>
>       <action issue="VFS-692" dev="ggregory" type="update" due-to="Gary
> Gregory">
>         Update Apache Commons Collections from 4.2 to 4.3.
>       </action>
>
>       <action                 dev="ggregory" type="update" due-to="Boris
> Petrov, Gary Gregory">
>         Add support for customizing FTP transfer aborted status codes.
> GitHub PR #51.
>       </action>
>
> The first entry uses a JIRA reference as usual.
>
> In the second entry, I applied a PR from GitHub but I did not create a
> matching JIRA issue. The fact that we have a change is still tracked in
> changes.xml. The site report will not have a URL to JIRA.
>
> Question: Can we make the changes plugin generate a link to GitHub for a PR?

http://maven.apache.org/plugins/maven-changes-plugin/changes-report-mojo.html#issueLinkTemplatePerSystem

I don't think the plugin can support more that one type of URL
generation per pom.
It would need some way to distinguish different types of issues.
e.g. a different attribute name (gitpr) or an extra attribute to
qualify the issue type.

This is really a question for the Maven user list.

> Gary

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Avoiding duplication of work between GitHub PRs and JIRA

garydgregory
On Wed, Mar 6, 2019 at 9:06 AM sebb <[hidden email]> wrote:

> On Wed, 6 Mar 2019 at 13:54, Gary Gregory <[hidden email]> wrote:
> >
> > Hi All:
> >
> > I'll start with this example from Commons VFS and its changes.xml:
> >
> >       <action issue="VFS-692" dev="ggregory" type="update" due-to="Gary
> > Gregory">
> >         Update Apache Commons Collections from 4.2 to 4.3.
> >       </action>
> >
> >       <action                 dev="ggregory" type="update" due-to="Boris
> > Petrov, Gary Gregory">
> >         Add support for customizing FTP transfer aborted status codes.
> > GitHub PR #51.
> >       </action>
> >
> > The first entry uses a JIRA reference as usual.
> >
> > In the second entry, I applied a PR from GitHub but I did not create a
> > matching JIRA issue. The fact that we have a change is still tracked in
> > changes.xml. The site report will not have a URL to JIRA.
> >
> > Question: Can we make the changes plugin generate a link to GitHub for a
> PR?
>
>
> http://maven.apache.org/plugins/maven-changes-plugin/changes-report-mojo.html#issueLinkTemplatePerSystem
>
> I don't think the plugin can support more that one type of URL
> generation per pom.
> It would need some way to distinguish different types of issues.
> e.g. a different attribute name (gitpr) or an extra attribute to
> qualify the issue type.
>
> This is really a question for the Maven user list.
>

Good idea. I just did. Thanks Sebb!

Gary


>
> > Gary
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Avoiding duplication of work between GitHub PRs and JIRA

Benedikt Ritter-4
I think for all non cosmetic changes there should be jira issue for the PR.
Source code platforms can come and go (think of SourceForge) so we should
not rely on the GitHub PR as documentation.

Benedikt

Am Mi., 6. März 2019 um 15:14 Uhr schrieb Gary Gregory <
[hidden email]>:

> On Wed, Mar 6, 2019 at 9:06 AM sebb <[hidden email]> wrote:
>
> > On Wed, 6 Mar 2019 at 13:54, Gary Gregory <[hidden email]>
> wrote:
> > >
> > > Hi All:
> > >
> > > I'll start with this example from Commons VFS and its changes.xml:
> > >
> > >       <action issue="VFS-692" dev="ggregory" type="update" due-to="Gary
> > > Gregory">
> > >         Update Apache Commons Collections from 4.2 to 4.3.
> > >       </action>
> > >
> > >       <action                 dev="ggregory" type="update"
> due-to="Boris
> > > Petrov, Gary Gregory">
> > >         Add support for customizing FTP transfer aborted status codes.
> > > GitHub PR #51.
> > >       </action>
> > >
> > > The first entry uses a JIRA reference as usual.
> > >
> > > In the second entry, I applied a PR from GitHub but I did not create a
> > > matching JIRA issue. The fact that we have a change is still tracked in
> > > changes.xml. The site report will not have a URL to JIRA.
> > >
> > > Question: Can we make the changes plugin generate a link to GitHub for
> a
> > PR?
> >
> >
> >
> http://maven.apache.org/plugins/maven-changes-plugin/changes-report-mojo.html#issueLinkTemplatePerSystem
> >
> > I don't think the plugin can support more that one type of URL
> > generation per pom.
> > It would need some way to distinguish different types of issues.
> > e.g. a different attribute name (gitpr) or an extra attribute to
> > qualify the issue type.
> >
> > This is really a question for the Maven user list.
> >
>
> Good idea. I just did. Thanks Sebb!
>
> Gary
>
>
> >
> > > Gary
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Avoiding duplication of work between GitHub PRs and JIRA

garydgregory
On Wed, Mar 6, 2019 at 9:20 AM Benedikt Ritter <[hidden email]> wrote:

> I think for all non cosmetic changes there should be jira issue for the PR.
> Source code platforms can come and go (think of SourceForge) so we should
> not rely on the GitHub PR as documentation.
>

I created a JIRA issue and updated the changes.xml.

Gary


>
> Benedikt
>
> Am Mi., 6. März 2019 um 15:14 Uhr schrieb Gary Gregory <
> [hidden email]>:
>
> > On Wed, Mar 6, 2019 at 9:06 AM sebb <[hidden email]> wrote:
> >
> > > On Wed, 6 Mar 2019 at 13:54, Gary Gregory <[hidden email]>
> > wrote:
> > > >
> > > > Hi All:
> > > >
> > > > I'll start with this example from Commons VFS and its changes.xml:
> > > >
> > > >       <action issue="VFS-692" dev="ggregory" type="update"
> due-to="Gary
> > > > Gregory">
> > > >         Update Apache Commons Collections from 4.2 to 4.3.
> > > >       </action>
> > > >
> > > >       <action                 dev="ggregory" type="update"
> > due-to="Boris
> > > > Petrov, Gary Gregory">
> > > >         Add support for customizing FTP transfer aborted status
> codes.
> > > > GitHub PR #51.
> > > >       </action>
> > > >
> > > > The first entry uses a JIRA reference as usual.
> > > >
> > > > In the second entry, I applied a PR from GitHub but I did not create
> a
> > > > matching JIRA issue. The fact that we have a change is still tracked
> in
> > > > changes.xml. The site report will not have a URL to JIRA.
> > > >
> > > > Question: Can we make the changes plugin generate a link to GitHub
> for
> > a
> > > PR?
> > >
> > >
> > >
> >
> http://maven.apache.org/plugins/maven-changes-plugin/changes-report-mojo.html#issueLinkTemplatePerSystem
> > >
> > > I don't think the plugin can support more that one type of URL
> > > generation per pom.
> > > It would need some way to distinguish different types of issues.
> > > e.g. a different attribute name (gitpr) or an extra attribute to
> > > qualify the issue type.
> > >
> > > This is really a question for the Maven user list.
> > >
> >
> > Good idea. I just did. Thanks Sebb!
> >
> > Gary
> >
> >
> > >
> > > > Gary
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Avoiding duplication of work between GitHub PRs and JIRA

Gilles Sadowski-2
In reply to this post by Benedikt Ritter-4
Hi.

Le mer. 6 mars 2019 à 15:20, Benedikt Ritter <[hidden email]> a écrit :
>
> I think for all non cosmetic changes there should be jira issue for the PR.

+1

> Source code platforms can come and go (think of SourceForge) so we should
> not rely on the GitHub PR as documentation.

+1

And I'd like to stress again that using GitHub for discussion is also
duplicating work, and potentially leaves out reviewers.

Gilles

>
> Benedikt
>
> Am Mi., 6. März 2019 um 15:14 Uhr schrieb Gary Gregory <
> [hidden email]>:
>
> > On Wed, Mar 6, 2019 at 9:06 AM sebb <[hidden email]> wrote:
> >
> > > On Wed, 6 Mar 2019 at 13:54, Gary Gregory <[hidden email]>
> > wrote:
> > > >
> > > > Hi All:
> > > >
> > > > I'll start with this example from Commons VFS and its changes.xml:
> > > >
> > > >       <action issue="VFS-692" dev="ggregory" type="update" due-to="Gary
> > > > Gregory">
> > > >         Update Apache Commons Collections from 4.2 to 4.3.
> > > >       </action>
> > > >
> > > >       <action                 dev="ggregory" type="update"
> > due-to="Boris
> > > > Petrov, Gary Gregory">
> > > >         Add support for customizing FTP transfer aborted status codes.
> > > > GitHub PR #51.
> > > >       </action>
> > > >
> > > > The first entry uses a JIRA reference as usual.
> > > >
> > > > In the second entry, I applied a PR from GitHub but I did not create a
> > > > matching JIRA issue. The fact that we have a change is still tracked in
> > > > changes.xml. The site report will not have a URL to JIRA.
> > > >
> > > > Question: Can we make the changes plugin generate a link to GitHub for
> > a
> > > PR?
> > >
> > >
> > >
> > http://maven.apache.org/plugins/maven-changes-plugin/changes-report-mojo.html#issueLinkTemplatePerSystem
> > >
> > > I don't think the plugin can support more that one type of URL
> > > generation per pom.
> > > It would need some way to distinguish different types of issues.
> > > e.g. a different attribute name (gitpr) or an extra attribute to
> > > qualify the issue type.
> > >
> > > This is really a question for the Maven user list.
> > >
> >
> > Good idea. I just did. Thanks Sebb!
> >
> > Gary
> >
> >
> > >
> > > > Gary
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> > >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]