[ALL] Make checkstyle:check part of default maven goal?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[ALL] Make checkstyle:check part of default maven goal?

Benedikt Ritter-4
Hi,

one thing I always have to do when preparing a release is to fix all the
checkstyle and findbugs errors. This step could be eliminated if we added
checkstyle:check and findbugs:check to the maven default goal. This way it
would be executed on CI builds and we would see failing checkstyle/findbugs
right away.

WDYT?
Benedikt
Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Make checkstyle:check part of default maven goal?

Stefan Bodewig
On 2018-08-20, Benedikt Ritter wrote:

> one thing I always have to do when preparing a release is to fix all the
> checkstyle and findbugs errors. This step could be eliminated if we added
> checkstyle:check and findbugs:check to the maven default goal. This way it
> would be executed on CI builds and we would see failing checkstyle/findbugs
> right away.

As long as there is a way to disable it, I'm fine with that. Not all
components use checkstyle (which means they don't have to fix any
checkstyle errors before a release ;-).

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Make checkstyle:check part of default maven goal?

Gilles Sadowski
In reply to this post by Benedikt Ritter-4
Hello.

On Mon, 20 Aug 2018 08:45:03 +0200, Benedikt Ritter wrote:

> Hi,
>
> one thing I always have to do when preparing a release is to fix all
> the
> checkstyle and findbugs errors. This step could be eliminated if we
> added
> checkstyle:check and findbugs:check to the maven default goal. This
> way it
> would be executed on CI builds and we would see failing
> checkstyle/findbugs
> right away.

+1 for adding them on the Jenkins jobs.
-1 for making them called by default (reports are not necessary for
    each build while developing).

Before committing a contribution, I try to always run
  $ mvn site
and check whether the reports are clean; but sometimes I forget (to
either run or check all relevant reports), so it may be useful to
have a profile that would fail the build if one of the important
checks reports a violation. [Then, running with this profile on should
be required from a contributor, before submitting a PR.]

Best,
Gilles


>
> WDYT?
> Benedikt


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Make checkstyle:check part of default maven goal?

garydgregory
In reply to this post by Benedikt Ritter-4
The RAT check should be turned on by default IMO.

Gary

On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter <[hidden email]> wrote:

> Hi,
>
> one thing I always have to do when preparing a release is to fix all the
> checkstyle and findbugs errors. This step could be eliminated if we added
> checkstyle:check and findbugs:check to the maven default goal. This way it
> would be executed on CI builds and we would see failing checkstyle/findbugs
> right away.
>
> WDYT?
> Benedikt
>
Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Make checkstyle:check part of default maven goal?

Pascal Schumacher
At least RAT and clirr/japicmp should be part of default goal.

I'm personally prefer checkstyle and findbugs/spotbugs (although I
prefer error-prone nowadays) to be part of the default goal.

On Java 8+ it is also helpful to make javadoc part of the default goal.

I think it is very convenient to be able to execute everything with
"mvn" before committing and have the build fail if there are any
violations. It is also helpful for pull request, because travis can run
the default goal too.

By the way: lang and text already have all these as default goal and io
is just missing findbugs.

Cheers,
Pascal

Am 20.08.2018 um 21:06 schrieb Gary Gregory:

> The RAT check should be turned on by default IMO.
>
> Gary
>
> On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter <[hidden email]> wrote:
>
>> Hi,
>>
>> one thing I always have to do when preparing a release is to fix all the
>> checkstyle and findbugs errors. This step could be eliminated if we added
>> checkstyle:check and findbugs:check to the maven default goal. This way it
>> would be executed on CI builds and we would see failing checkstyle/findbugs
>> right away.
>>
>> WDYT?
>> Benedikt
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [ALL] Make checkstyle:check part of default maven goal?

Rob Tompkins


> On Aug 27, 2018, at 2:33 PM, Pascal Schumacher <[hidden email]> wrote:
>
> At least RAT and clirr/japicmp should be part of default goal.
>
> I'm personally prefer checkstyle and findbugs/spotbugs (although I prefer error-prone nowadays) to be part of the default goal.
>
> On Java 8+ it is also helpful to make javadoc part of the default goal.
>
> I think it is very convenient to be able to execute everything with "mvn" before committing and have the build fail if there are any violations. It is also helpful for pull request, because travis can run the default goal too.
>
> By the way: lang and text already have all these as default goal and io is just missing findbugs.
>
> Cheers,
> Pascal

I’m a +1 to this idea.

-Rob

>
>> Am 20.08.2018 um 21:06 schrieb Gary Gregory:
>> The RAT check should be turned on by default IMO.
>>
>> Gary
>>
>>> On Mon, Aug 20, 2018 at 12:45 AM Benedikt Ritter <[hidden email]> wrote:
>>>
>>> Hi,
>>>
>>> one thing I always have to do when preparing a release is to fix all the
>>> checkstyle and findbugs errors. This step could be eliminated if we added
>>> checkstyle:check and findbugs:check to the maven default goal. This way it
>>> would be executed on CI builds and we would see failing checkstyle/findbugs
>>> right away.
>>>
>>> WDYT?
>>> Benedikt
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]