[All] Help with GitHub "support"

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[All] Help with GitHub "support"

Gilles Sadowski-2
Hi.

Some people are providing PRs[1] on GitHub without engaging with
us, here, or on JIRA.
When this happens for codes[2] which I'm the assumed reviewer,[3]
I'd need help from someone, with a GitHub account, who would post
a comment there, in order to let the "outside" contributors know that
we won't apply PRs without tracking information (JIRA ticket and/or
post on "dev"), as per the "contributions guidelines".[4]

Thanks,
Gilles

[1] Last examples:
    https://github.com/apache/commons-math/pull/105
    https://github.com/apache/commons-statistics/pull/4
[2] "RNG", "Numbers", "Statistics"
[3] Unless someone else is willing to engage in reviewing the
proposal on GitHub, and perform the merge.
[4] http://commons.apache.org/patches.html

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [All] Help with GitHub "support"

Bruno P. Kinoshita-2
 Commented on the two PRs linked here. I am almost through the commons-imaging-1.0-alpha1 release (finally!). After that I will finally be able to use more development time to run through components with pending PR's and issues, and try to reply to some of these contributors.
Thanks Gilles!
Bruno

    On Thursday, 2 May 2019, 10:56:25 pm NZST, Gilles Sadowski <[hidden email]> wrote:  
 
 Hi.

Some people are providing PRs[1] on GitHub without engaging with
us, here, or on JIRA.
When this happens for codes[2] which I'm the assumed reviewer,[3]
I'd need help from someone, with a GitHub account, who would post
a comment there, in order to let the "outside" contributors know that
we won't apply PRs without tracking information (JIRA ticket and/or
post on "dev"), as per the "contributions guidelines".[4]

Thanks,
Gilles

[1] Last examples:
    https://github.com/apache/commons-math/pull/105
    https://github.com/apache/commons-statistics/pull/4
[2] "RNG", "Numbers", "Statistics"
[3] Unless someone else is willing to engage in reviewing the
proposal on GitHub, and perform the merge.
[4] http://commons.apache.org/patches.html

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

 
Reply | Threaded
Open this post in threaded view
|

Re: [All] Help with GitHub "support"

Alex Herbert
Hi Gilles,

I saw the PR for Statistics and noted that it was a trivial change that
may not be warranted, or at least not in the form provided. I'll make
more time to watch PRs for those projects you mentioned.

Alex

On 02/05/2019 12:32, Bruno P. Kinoshita wrote:

>   Commented on the two PRs linked here. I am almost through the commons-imaging-1.0-alpha1 release (finally!). After that I will finally be able to use more development time to run through components with pending PR's and issues, and try to reply to some of these contributors.
> Thanks Gilles!
> Bruno
>
>      On Thursday, 2 May 2019, 10:56:25 pm NZST, Gilles Sadowski <[hidden email]> wrote:
>  
>   Hi.
>
> Some people are providing PRs[1] on GitHub without engaging with
> us, here, or on JIRA.
> When this happens for codes[2] which I'm the assumed reviewer,[3]
> I'd need help from someone, with a GitHub account, who would post
> a comment there, in order to let the "outside" contributors know that
> we won't apply PRs without tracking information (JIRA ticket and/or
> post on "dev"), as per the "contributions guidelines".[4]
>
> Thanks,
> Gilles
>
> [1] Last examples:
>      https://github.com/apache/commons-math/pull/105
>      https://github.com/apache/commons-statistics/pull/4
> [2] "RNG", "Numbers", "Statistics"
> [3] Unless someone else is willing to engage in reviewing the
> proposal on GitHub, and perform the merge.
> [4] http://commons.apache.org/patches.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>    

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [All] Help with GitHub "support"

Gilles Sadowski-2
Thank you Bruno and Alex!

Best,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [All] Help with GitHub "support"

Eric Barnhill
In reply to this post by Gilles Sadowski-2
I am happy to review PRs and approve merges as well, it's become part of my
daily routine at work to use GitHub in this way, so it's no trouble.

On Thu, May 2, 2019 at 3:56 AM Gilles Sadowski <[hidden email]> wrote:

> Hi.
>
> Some people are providing PRs[1] on GitHub without engaging with
> us, here, or on JIRA.
> When this happens for codes[2] which I'm the assumed reviewer,[3]
> I'd need help from someone, with a GitHub account, who would post
> a comment there, in order to let the "outside" contributors know that
> we won't apply PRs without tracking information (JIRA ticket and/or
> post on "dev"), as per the "contributions guidelines".[4]
>
> Thanks,
> Gilles
>
> [1] Last examples:
>     https://github.com/apache/commons-math/pull/105
>     https://github.com/apache/commons-statistics/pull/4
> [2] "RNG", "Numbers", "Statistics"
> [3] Unless someone else is willing to engage in reviewing the
> proposal on GitHub, and perform the merge.
> [4] http://commons.apache.org/patches.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [All] Help with GitHub "support"

Otto Fowler
You could add a PR template to github, and put a big banner in there that
says something like that.


On May 2, 2019 at 11:54:34, Eric Barnhill ([hidden email]) wrote:

I am happy to review PRs and approve merges as well, it's become part of my
daily routine at work to use GitHub in this way, so it's no trouble.

On Thu, May 2, 2019 at 3:56 AM Gilles Sadowski <[hidden email]>
wrote:

> Hi.
>
> Some people are providing PRs[1] on GitHub without engaging with
> us, here, or on JIRA.
> When this happens for codes[2] which I'm the assumed reviewer,[3]
> I'd need help from someone, with a GitHub account, who would post
> a comment there, in order to let the "outside" contributors know that
> we won't apply PRs without tracking information (JIRA ticket and/or
> post on "dev"), as per the "contributions guidelines".[4]
>
> Thanks,
> Gilles
>
> [1] Last examples:
> https://github.com/apache/commons-math/pull/105
> https://github.com/apache/commons-statistics/pull/4
> [2] "RNG", "Numbers", "Statistics"
> [3] Unless someone else is willing to engage in reviewing the
> proposal on GitHub, and perform the merge.
> [4] http://commons.apache.org/patches.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [All] Help with GitHub "support"

jochen-2
In reply to this post by Gilles Sadowski-2
I think, that Gilles is right in pointing out, that the current policy
(accept patches only with explicit, or implicit, acceptance of
contribution under the ASL) clashes somehow with Github PR's in that
it is difficult to assume implicit acceptance in that cases.

However, I don't think that this question is in any way restricted to
Commons. So, I don't think, that our dev list is the proper place to
have this discussion. Besides, I'd assume that the question has been
discussed in advance before Gitbox has been established. My
recommendation would be to create a Jira issue for INFRA, or LEGAL,
where we point out the question, and request clarification.

Jochen


On Thu, May 2, 2019 at 12:56 PM Gilles Sadowski <[hidden email]> wrote:

>
> Hi.
>
> Some people are providing PRs[1] on GitHub without engaging with
> us, here, or on JIRA.
> When this happens for codes[2] which I'm the assumed reviewer,[3]
> I'd need help from someone, with a GitHub account, who would post
> a comment there, in order to let the "outside" contributors know that
> we won't apply PRs without tracking information (JIRA ticket and/or
> post on "dev"), as per the "contributions guidelines".[4]
>
> Thanks,
> Gilles
>
> [1] Last examples:
>     https://github.com/apache/commons-math/pull/105
>     https://github.com/apache/commons-statistics/pull/4
> [2] "RNG", "Numbers", "Statistics"
> [3] Unless someone else is willing to engage in reviewing the
> proposal on GitHub, and perform the merge.
> [4] http://commons.apache.org/patches.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]