[Compress]New PRs on github need reviews

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Compress]New PRs on github need reviews

Peter Lee
Hi all,

I'm Lee and I'm new to commons-compress. I'm a amateur in compression
algorithms. I like commons-compress cause it supports so many
specifications. I'd like to contribute to it.

Recently I pushed 3 PRs in github :
1. Add support for Tar with sparse entries
2. the split/spanned zip support(extracting and constructing)
I believe Stefan is reviewing the PR about split/spanned zip, but it seems
no one is reviewing the other one. I'm hoping if someone could give me some
reviews if time permits, therefore I can make it better. :)

Best regards,
Lee
Reply | Threaded
Open this post in threaded view
|

Re: [Compress]New PRs on github need reviews

Torsten Curdt-3
I've added some comments/questions to the PR for Tar.

cheers,
Torsten

On Tue, Nov 26, 2019 at 4:46 AM Peter Lee <[hidden email]> wrote:

> Hi all,
>
> I'm Lee and I'm new to commons-compress. I'm a amateur in compression
> algorithms. I like commons-compress cause it supports so many
> specifications. I'd like to contribute to it.
>
> Recently I pushed 3 PRs in github :
> 1. Add support for Tar with sparse entries
> 2. the split/spanned zip support(extracting and constructing)
> I believe Stefan is reviewing the PR about split/spanned zip, but it seems
> no one is reviewing the other one. I'm hoping if someone could give me some
> reviews if time permits, therefore I can make it better. :)
>
> Best regards,
> Lee
>
Reply | Threaded
Open this post in threaded view
|

Re: [Compress]New PRs on github need reviews

Peter Lee
Thank you Torsten and melloware for your reviews.

The other 2 PRs about extracting and creating split/spanned zip are also
welcome to your reviews if time allows.They contain a lot lines of code and
may take some more time to review. I believe it will be a little difficult
for Stefan to review them alone. Maybe someone can help.

I like commons-compress and I want to keep my code as clear as I can. I
will try my best to answer your reviews ASAP. Hoping my PRs can improve
commons-compress a little bit.

Best regards,
Lee

Torsten Curdt <[hidden email]> 于2019年11月26日周二 下午6:42写道:

> I've added some comments/questions to the PR for Tar.
>
> cheers,
> Torsten
>
> On Tue, Nov 26, 2019 at 4:46 AM Peter Lee <[hidden email]>
> wrote:
>
> > Hi all,
> >
> > I'm Lee and I'm new to commons-compress. I'm a amateur in compression
> > algorithms. I like commons-compress cause it supports so many
> > specifications. I'd like to contribute to it.
> >
> > Recently I pushed 3 PRs in github :
> > 1. Add support for Tar with sparse entries
> > 2. the split/spanned zip support(extracting and constructing)
> > I believe Stefan is reviewing the PR about split/spanned zip, but it
> seems
> > no one is reviewing the other one. I'm hoping if someone could give me
> some
> > reviews if time permits, therefore I can make it better. :)
> >
> > Best regards,
> > Lee
> >
>