------- Additional Comments From [hidden email] 2005-06-02 09:51 -------
As part of your patch to add a configurable "ignore flawed discovery" feature,
could you please consider handing the cast to Log in this line:
logAdapter = (Log) constructor.newInstance(params);
separately from the other exceptions?
Currently, the code catches all throwables and passes the exception down to
handleFlawedDiscovery, which then assumes that a ClassCastException was due to
casting the result to Log. This isn't necessarily true. I think it would be nice
if the return value from constructor.newInstance was initially treated as an
Object. Casting could then be done in a separate try/catch clause, and only
ClassCastException in *that* block would mean calling reportInvalidLogAdapter.
Anyway, I think it's worth considering...and as I know you're already working on
these methods it didn't seem wise for me to be working on the same code at the
same time :).
PS: When affectState is false, do wewant to call handleFlawedDiscovery? I