DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl

Bugzilla from bugzilla@apache.org
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG?
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34661>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND?
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34661





------- Additional Comments From [hidden email]  2005-06-02 17:56 -------
(In reply to comment #25)
> (In reply to comment #23)
> > I'm opposed to attempting to load a specific adapter from the parent
classpath
> > if one is found in the child classpath which doesn't work.
>
> Sorry, I got confused. This is only going to happen when getLog is called from
> code in the parent classpath. And there just isn't any other solution anyway.
>
> I'll have a look at the patch (#21) now.
>

Actually, I'm glad you raised this point, as it got me thinking how to respond,
and I thought of a couple issues.  Was thinking in shower and car, so may be off
a bit, but:

1) This logic should only be invoked in cases of ClassCastException, not
InvocationTargetException, etc.
2) What if there is a commons-logging.properties in the child?  There will be
some strange interactions here:
 a) If the Log adapter specified by commmons-logging.properties CAN be loaded by
the parent, it will be, even if that's not what would be normally discovered at
the parent level.
 b) If the Log adapter specified by commmons-logging.properties CANNOT be loaded
by the parent, JCL will fail, as we do not allow normal discovery to proceed.



--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]