------- Additional Comments From [hidden email] 2005-06-03 07:02 -------
(In reply to comment #26)
> 1) This logic should only be invoked in cases of ClassCastException, not
> InvocationTargetException, etc.
Actually, only when ClassCastException happens when trying to convert to Log..
(2a) This sounds ok to me. The user wanted that logging lib, and they didn't
specify FailOnHierarchyError (or whatever we call it)
(2b) This sounds ok to me. The user didn't want discovery..
On related matters, I would prefer not to take the approach:
* try context
* try classloader of the LogFactoryImpl.
I think it would be better to start at the context classloader and walk up the
classloader inheritance tree until reaching the classloader that loaded the
LogFactoryImpl. I've been playing with various ways of achieving this, but it
isn't easy when you also need to treat exceptions as fatal or recoverable along
the way. Opinions?