DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

DO NOT REPLY [Bug 34661] - [logging][PATCH] Improvements to LogFactoryImpl

Bugzilla from bugzilla@apache.org
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG?
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34661>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND?
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34661





------- Additional Comments From [hidden email]  2005-06-12 05:40 -------
(In reply to comment #34)
> (In reply to comment #32)
> > 1) Invocation of constructor in createLogFromClass
>
> I think this should be fixed in LogKitLogger rather than in LogFactoryImpl.
>
<snip>

>
> It's difficult to tell these apart, but I would suggest specifying (in the Log
> interface javadoc) that a NoClassDefFound or an ExceptionInInitializerError
> should indicate "not available" while an InvocationTargetException indicates
> available-but-broken. This is the approach that I took with Jdk14Logger, where
> there is a dummy variable that forces an ExceptionInInitializerError if
> java.util.logging.Level is not available. I expect a similar thing could be done
> with LogKitLogger...
>
> Thoughts?

+1.  I was about 65% of that opinion when I added that big comment in the patch :)

--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]