[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

classic Classic list List threaded Threaded
39 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
GitHub user rubin55 opened a pull request:

    https://github.com/apache/commons-cli/pull/15

    CLI-217: Optional partial matching

    At request of Gary, I (re)created an old patch against the current code base to enable partial matching to be set as optional. This fixes problems for people that have short options that, concatenated, also partial-match a long option.
   
    For example:
        -d, --debug
        -e, --extract
   
        foo -de
   
    Is ambiguous in the case that partial matching is enabled. This patch allows a user to turn off partial matching in such a case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rubin55/commons-cli master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-cli/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
   
----
commit 186612c45b973f0b2f9e7a5a9ee97a6e3bfc3cad
Author: Rubin Simons <[hidden email]>
Date:   2017-06-22T13:33:03Z

    Ignore IDE specific files

commit 6e7850b99024032c8cf4979d2eea61302dfd6a09
Author: Rubin Simons <[hidden email]>
Date:   2017-06-23T09:51:56Z

    Ignore IntelliJ IDEA files too

commit bdb4a09ceaceab7e3d214b1beadb93bd9c911342
Author: Rubin Simons <[hidden email]>
Date:   2017-06-23T11:04:27Z

    Added support for disabling partial option matching

commit 4f17a89ad04bcf718aeac43d202f8c261ce0b796
Author: Rubin Simons <[hidden email]>
Date:   2017-06-23T11:04:59Z

    Added tests for partial matching enable/disable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
   
    [![Coverage Status](https://:/builds/12101592/badge)](https://:/builds/12101592)
   
    Coverage decreased (-0.1%) to 96.122% when pulling **4f17a89ad04bcf718aeac43d202f8c261ce0b796 on rubin55:master** into **c246bd419ee0efccd9a96f9d33486617d5d38a56 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
   
    [![Coverage Status](https://:/builds/12101592/badge)](https://:/builds/12101592)
   
    Coverage decreased (-0.1%) to 96.122% when pulling **4f17a89ad04bcf718aeac43d202f8c261ce0b796 on rubin55:master** into **c246bd419ee0efccd9a96f9d33486617d5d38a56 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
   
    [![Coverage Status](https://:/builds/12154396/badge)](https://:/builds/12154396)
   
    Coverage increased (+0.04%) to 96.287% when pulling **3d9587caec7dd23d359bc112c63512e2bc3e0702 on rubin55:master** into **c246bd419ee0efccd9a96f9d33486617d5d38a56 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
   
    [![Coverage Status](https://:/builds/12154396/badge)](https://:/builds/12154396)
   
    Coverage increased (+0.04%) to 96.287% when pulling **3d9587caec7dd23d359bc112c63512e2bc3e0702 on rubin55:master** into **c246bd419ee0efccd9a96f9d33486617d5d38a56 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user rubin55 commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    Is someone looking at this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user rubin55 commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    Is someone looking at this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user britter commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    @rubin55 sorry, I'm currently burried in work. Maybe @chtompki or @kinow can have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user britter commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    @rubin55 sorry, I'm currently burried in work. Maybe @chtompki or @kinow can have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125636671
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    I'm not sure we want to change the `.gitignore` file. I would think these entries would be in one's global `.gitignore` file as the project itself does not generate these files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125636671
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    I'm not sure we want to change the `.gitignore` file. I would think these entries would be in one's global `.gitignore` file as the project itself does not generate these files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user rubin55 commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125648975
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    Do you want me to undo that change? it's not a huge issue from my perspective, but no ish if you'd rather have it without!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user rubin55 commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125648975
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    Do you want me to undo that change? it's not a huge issue from my perspective, but no ish if you'd rather have it without!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125655784
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    Nah...I'll work around it...plus it's a change to an SVN project, so I've got to copy in your changes. That reminds me, maybe I'll take collections and promote it to being a git repo in the apache infrastructure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125655784
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    Nah...I'll work around it...plus it's a change to an SVN project, so I've got to copy in your changes. That reminds me, maybe I'll take collections and promote it to being a git repo in the apache infrastructure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125656068
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    Ha...pardon...wrong project. Nevermind about the copy bit. @britter just promoted CLI to git.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli pull request #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-cli/pull/15#discussion_r125656068
 
    --- Diff: .gitignore ---
    @@ -1,5 +1,4 @@
    -### https://raw.github.com/github/gitignore/f2ce448f2ba7a092da05482ceca99209127c0884/maven.gitignore
    -
    +# maven
    --- End diff --
   
    Ha...pardon...wrong project. Nevermind about the copy bit. @britter just promoted CLI to git.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    Yes aside from the `.gitignore` changes, this all looks quite reasonable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    Yes aside from the `.gitignore` changes, this all looks quite reasonable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

kinow
In reply to this post by kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-cli/pull/15
 
    Looking at [CLI-217.patch](https://issues.apache.org/jira/secure/attachment/12568952/CLI-217.patch), I was wondering if we shouldn't also include changes to `PosixParser`? The changes would be at https://github.com/apache/commons-cli/blob/master/src/main/java/org/apache/commons/cli/PosixParser.java#L127 and https://github.com/apache/commons-cli/blob/master/src/main/java/org/apache/commons/cli/PosixParser.java#L134 based on the bottom of that patch file. No worries if there is a distinct reason for not including those, just curious if you saw that in the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12
Loading...