[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

kinow
GitHub user ameyjadiye opened a pull request:

    https://github.com/apache/commons-cli/pull/16

    added findbug and checkstyle support while building

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ameyjadiye/commons-cli master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-cli/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
   
----
commit d6dcadb6d7c8a25996a0e71ec482c419ae963ea0
Author: Amey Jadiye <[hidden email]>
Date:   2017-08-01T18:45:47Z

    added findbug and checkstyle support while building

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
   
    [![Coverage Status](https://coveralls.io/builds/12646111/badge)](https://coveralls.io/builds/12646111)
   
    Coverage remained the same at 96.287% when pulling **d6dcadb6d7c8a25996a0e71ec482c419ae963ea0 on ameyjadiye:master** into **34fe9e5250a1a568b52ba277fdc86314c20aece3 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
   
    [![Coverage Status](https://coveralls.io/builds/12646111/badge)](https://coveralls.io/builds/12646111)
   
    Coverage remained the same at 96.287% when pulling **d6dcadb6d7c8a25996a0e71ec482c419ae963ea0 on ameyjadiye:master** into **34fe9e5250a1a568b52ba277fdc86314c20aece3 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    @PascalSchumacher , can you take a look at this ? seems only issue with findbug on  java6 build, rest seems Ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    @PascalSchumacher , can you take a look at this ? seems only issue with findbug on  java6 build, rest seems Ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    The findbugs version used is not java 6 compatible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    The findbugs version used is not java 6 compatible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

kinow
In reply to this post by kinow
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-cli/pull/16


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

kinow
In reply to this post by kinow
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-cli/pull/16


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    @chtompki , is this not accepted ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    @chtompki , is this not accepted ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    Oh pardon. I misread. I’ll re-run through it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    Oh pardon. I misread. I’ll re-run through it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    As I said before this can not be merged as it is, because it fails on java 6.
   
    The simple fix of just downgrading the findbugs version can not be applied, because 2.x versions do not work on java 8. A possible solution would be to create a java 6 profile which detects java 6 and with uses the java 6 compatible maven-findbugs-plugin version 2.x.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    As I said before this can not be merged as it is, because it fails on java 6.
   
    The simple fix of just downgrading the findbugs version can not be applied, because 2.x versions do not work on java 8. A possible solution would be to create a java 6 profile which detects java 6 and with uses the java 6 compatible maven-findbugs-plugin version 2.x.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    Thanks!
   
    I solved the findbugs version problem with: https://github.com/apache/commons-cli/commit/2392ae8afc08b496a3eb49908aa421ea86a9679e


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    Thanks!
   
    I solved the findbugs version problem with: https://github.com/apache/commons-cli/commit/2392ae8afc08b496a3eb49908aa421ea86a9679e


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    Thanks @PascalSchumacher


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-cli/pull/16
 
    Thanks @PascalSchumacher


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]