[GitHub] [commons-codec] Claudenw commented on issue #27: Murmur3fix

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-codec] Claudenw commented on issue #27: Murmur3fix

GitBox
Claudenw commented on issue #27: Murmur3fix
URL: https://github.com/apache/commons-codec/pull/27#issuecomment-552122576
 
 
   The latest attempt leaves the earlier code in place but deprecates it with a note about the sign extension error.  There is no change to the existing code (despite the change detected by git) except for:
   
   1 the deprecated annotation.
   2. the deprecated javadoc tag which says to use the newer version.
   3. addition to the 128 bit  method javadocs that indicate the existence of the sign extension error.
   
   New methods are named
   hash32_x86and hash128_x64
   
   Addition of UBYTE_MASK, UBYTE_LONG_MASK, and UINT_MASK.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services