[GitHub] [commons-codec] aherbert commented on issue #32: [codec-259] Hex: consume all ByteBuffer.remaining() bytes

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-codec] aherbert commented on issue #32: [codec-259] Hex: consume all ByteBuffer.remaining() bytes

GitBox
aherbert commented on issue #32: [codec-259] Hex: consume all ByteBuffer.remaining() bytes
URL: https://github.com/apache/commons-codec/pull/32#issuecomment-560837213
 
 
   Coverage drops because the HexTest no longer uses:
   ```
   digest.StringUtils:
       public static ByteBuffer getByteBufferUtf8(final String string) {
   ```
   
   This method seems to have been introduced for the sole purpose of use in the HexTest. There is no other usage in the codec code. It is out of place in digest.StringUtils as there are no other methods for other encodings that return a ByteBuffer. All the others return byte[].
   
   I can add a test to StringUtilsTest to get coverage back. I think the method should be deprecated.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services