[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution
URL: https://github.com/apache/commons-collections/pull/83#issuecomment-531056649
 
 
   Hi @Claudenw
   
   In order to improve you code coverage, you need to generate a JaCoCo report like this one:
   
   http://commons.apache.org/proper/commons-collections/jacoco/index.html
   
   Using this command:
   ```
   mvn clean package site -P jacoco
   ```
   
   This will generate a site in `target\site`.
   
   Also, running `mvn javadoc:javadoc` will reveal some but not all Javadoc issues.
   
   For example, you use `@see AbstractBloomFilter.getApproximateLog()` but the notation needs a `#` not a `.` and the class `AbstractBloomFilter` is not part of this patch anyway, so it's a double whammy ;-)
   
   The method `org.apache.commons.collections4.bloomfilters.ProtoBloomFilterBuilder.build(byte[])` does not need to declare `IOException` as it does not actually throw it.
   
   If you fix all of these error, you will be able to run the JaCoCo report based on the Maven command above and see that the current tests only cover **26%** of the code.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services