[GitHub] commons-collections pull request #29: Added unit tests to increase coverage

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #29: Added unit tests to increase coverage

kinow
GitHub user vamsi-kavuri opened a pull request:

    https://github.com/apache/commons-collections/pull/29

    Added unit tests to increase coverage

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vamsi-kavuri/commons-collections Unit_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #29
   
----
commit bcaa1484b830a45b5ae8f975ba8816a48cc462ed
Author: Kavuri, Vamsi <[hidden email]>
Date:   2017-06-12T16:37:26Z

    COLLECTIONS-606:Added build and coverage status

commit 676c353e0c24450ac4fc1435db1b8e0df3384e3b
Author: Vamsi <[hidden email]>
Date:   2017-06-12T16:43:03Z

    Merge pull request #1 from vamsi-kavuri/COLLECTIONS-606-BuildStatus
   
    COLLECTIONS-606:Added build and coverage status

commit cc079f8c834d505b8485da1ebd935ee269600628
Author: Kavuri, Vamsi <[hidden email]>
Date:   2017-10-10T02:40:55Z

    Merge branch 'master' of https://github.com/apache/commons-collections into COLLECTIONS-606-BuildStatus

commit d6e4c2e98b525b4553ef0baab76246c2b9a0ae70
Author: Kavuri, Vamsi <[hidden email]>
Date:   2017-10-11T21:46:05Z

    Add unit test cases

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
   
    [![Coverage Status](https://coveralls.io/builds/13678056/badge)](https://coveralls.io/builds/13678056)
   
    Coverage increased (+1.5%) to 86.616% when pulling **d6e4c2e98b525b4553ef0baab76246c2b9a0ae70 on vamsi-kavuri:Unit_tests** into **1d21a49c27d9eab8d02785a783fcfba387a3e8e1 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #29: Added unit tests to increase code cove...

kinow
In reply to this post by kinow
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-collections/pull/29


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #29: Added unit tests to increase code cove...

kinow
In reply to this post by kinow
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-collections/pull/29


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
    Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
    `assertEquals(MapUtils.getDouble(in,"key", 0.0), 2.0, 0);` etc. should be `assertEquals(2.0, MapUtils.getDouble(in,"key", 0.0), 0);` because it is `assertEquals(double expected, double actual, double delta)`
   
    Also two test fail for locales that do no use `.` as the decimal separator (e.g. germany)
   
    ```
    Failed tests:
      MapUtilsTest.testgetDoubleValue:956 expected:<20.0> but was:<2.0>
      MapUtilsTest.testgetFloatValue:974 expected:<20.0> but was:<2.0>
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
In reply to this post by kinow
Github user vamsi-kavuri commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
    @PascalSchumacher Thanks for the feedback. I haven't thought of german locale. good catch. I will update it in a different PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
    Thanks! Looking forward to the pull request!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
In reply to this post by kinow
Github user vamsi-kavuri commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
    @PascalSchumacher I am late by an hour. Decimal separators are added by gregory
    https://github.com/apache/commons-collections/commit/641aa1c663ebead0189bf001a06ee56463070ddb



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #29: Added unit tests to increase code coverage

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-collections/pull/29
 
    Sorry about that. :(
   
    But the correct parameter order part of you pull request is still relevant. It would be nice if you could create a new rebased pull request for that. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]