[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

ttulka
GitHub user drajakumar opened a pull request:

    https://github.com/apache/commons-collections/pull/57

    COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion…

    … when it receives itself

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drajakumar/commons-collections master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
   
----
commit be0cea3c907bb4ab1083384377521942d17e15bd
Author: Don Jeba <donjeba@...>
Date:   2018-11-08T17:36:05Z

    COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion when it receives itself

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

ttulka
Github user garydgregory commented on the issue:

    https://github.com/apache/commons-collections/pull/57
 
    Hi @drajakumar ,
   
    I'm not sure this patch makes sense. Take a look at ```org.apache.commons.collections4.list.Collections701Test```: For ```ArrayList``` and ```HashSet```, adding a collection to itself is fine.
   
    In this patch, the argument is not only silently ignored, but the behavior is not even documented. Whatever we do, we really need to document _anything_ that deviates from the standard JRE ```List``` contract.
   
    IMO, the fix should be so that a ```SetUniqueList``` behaves like a ```ArrayList``` and ```HashSet```, it just works.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

ttulka
In reply to this post by ttulka
Github user drajakumar commented on the issue:

    https://github.com/apache/commons-collections/pull/57
 
    closing the pr as the fix is not as expected


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

ttulka
In reply to this post by ttulka
Github user drajakumar closed the pull request at:

    https://github.com/apache/commons-collections/pull/57


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

ttulka
In reply to this post by ttulka
Github user drajakumar closed the pull request at:

    https://github.com/apache/commons-collections/pull/57


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

ttulka
In reply to this post by ttulka
Github user garydgregory commented on the issue:

    https://github.com/apache/commons-collections/pull/57
 
    You did not have to close the PR, I was hoping you would provide a more complete solution ;-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

ttulka
In reply to this post by ttulka
Github user drajakumar commented on the issue:

    https://github.com/apache/commons-collections/pull/57
 
    sure @garydgregory  i am analyzing for a fix as per the expectation, will update you.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

ttulka
In reply to this post by ttulka
GitHub user drajakumar reopened a pull request:

    https://github.com/apache/commons-collections/pull/57

    COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion…

    … when it receives itself

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drajakumar/commons-collections master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
   
----
commit be0cea3c907bb4ab1083384377521942d17e15bd
Author: Don Jeba <donjeba@...>
Date:   2018-11-08T17:36:05Z

    COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion when it receives itself

commit ddde35c943058b55a59e88c9f5d60ed53f3e08ef
Author: Rajakumar <drajakumar@...>
Date:   2018-11-09T14:27:11Z

    Merge branch 'master' of github.com:apache/commons-collections

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...

ttulka
In reply to this post by ttulka
GitHub user drajakumar reopened a pull request:

    https://github.com/apache/commons-collections/pull/57

    COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion…

    … when it receives itself

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drajakumar/commons-collections master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
   
----
commit be0cea3c907bb4ab1083384377521942d17e15bd
Author: Don Jeba <donjeba@...>
Date:   2018-11-08T17:36:05Z

    COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion when it receives itself

commit ddde35c943058b55a59e88c9f5d60ed53f3e08ef
Author: Rajakumar <drajakumar@...>
Date:   2018-11-09T14:27:11Z

    Merge branch 'master' of github.com:apache/commons-collections

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

ttulka
In reply to this post by ttulka
Github user drajakumar commented on the issue:

    https://github.com/apache/commons-collections/pull/57
 
    @garydgregory can you kindly check the new fix, thank you!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...

ttulka
In reply to this post by ttulka
Github user drajakumar commented on the issue:

    https://github.com/apache/commons-collections/pull/57
 
    @garydgregory can you kindly check the new fix, thank you!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]