[GitHub] commons-collections pull request #63: [COLLECTIONS-707] Added PrefixMap - WI...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections pull request #63: [COLLECTIONS-707] Added PrefixMap - WI...

RahulNagekar
GitHub user nielsbasjes opened a pull request:

    https://github.com/apache/commons-collections/pull/63

    [COLLECTIONS-707] Added PrefixMap - WIP!

    First version of the PrefixMap implementation.
    I consider this a work in progress and expect various review comments.
   
    I have included two implementations of this interface:
    - StringPrefixMap where any String can be used as prefix.
    - ASCIIPrefixMap where only readable ASCII is allowed as the key. This restriction cuts the retrieval time in half and as such may be useful where speed is very important.
   
    About the tests:
    - I have to add more tests regarding special characters in the Prefix.
    - Right now there are also a few very simple performance tests to verify the lookup speed. It may be needed to remove these before committing.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nielsbasjes/commons-collections COLLECTIONS-707-PrefixMap

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
   
----
commit aab3af5b3eba732b12d4a87a093a881d89723a56
Author: Niels Basjes <nbasjes@...>
Date:   2018-11-30T21:59:12Z

    [COLLECTIONS-707] Added PrefixMap

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-collections issue #63: [COLLECTIONS-707] Added PrefixMap - WIP!

RahulNagekar
Github user nielsbasjes commented on the issue:

    https://github.com/apache/commons-collections/pull/63
 
    Code coverage is now 100% of the new code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]