[GitHub] [commons-compress] PeterAlfreadLee commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-compress] PeterAlfreadLee commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

GitBox
PeterAlfreadLee commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files
URL: https://github.com/apache/commons-compress/pull/84#issuecomment-552063435
 
 
   Just pushed some code to modify a minor bug:
   The zip split signature (0x08074B50) will only show up at the beginning of the first zip split segment, not every segment. So we should only validate if the first zip split segment is begun with split signature(0x08074B50).
   
   BTW:
   I have finished the code of building a split zip. I hope I can push my PR when this PR of extracting split zip is merged, because I want to write some testcases for the building of split zip.
   It's not easy to test a split zip in linux because the Zip command line tool only support constructing a split zip, not extracting them(I have to admit that this amazed me) and 7z in linux doesn't support split zip.
   I have no idea how can I test my constructed split zip in linux(on the other hand it's OK in Windows). If you have any ideas about it, I would highly appreciate it if you can teach me about it. @bodewig   :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services