[GitHub] commons-exec pull request #1: making CommandLine.addArgument and CommandLine...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-exec pull request #1: making CommandLine.addArgument and CommandLine...

kinow
GitHub user krichter722 opened a pull request:

    https://github.com/apache/commons-exec/pull/1

    making CommandLine.addArgument and CommandLine.addArguments fail on null and empty arguments

    Making CommandLine.addArgument and CommandLine.addArguments fail on null and empty (for addArguments) arguments which makes it easier to track unwanted behavior/arguments.
   
    This changes the API slightly, but imo it's more intuitive and error proof than before, i.e. the change would be appreciated by users.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/krichter722/commons-exec fail_on_null_and_empty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-exec/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1
   
----
commit 8a102f1bb42cd732b78de5281a7f92d78cc8c8f3
Author: Karl-Philipp Richter <[hidden email]>
Date:   2017-08-04T11:18:22Z

    making CommandLine.addArgument and CommandLine.addArguments fail on null and empty (for addArguments) arguments which makes it easier to track unwanted behavior/arguments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...