[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

kinow
GitHub user maxxedev opened a pull request:

    https://github.com/apache/commons-fileupload/pull/10

    FILEUPLOAD-286: allow default charset to be overridden.

    useful in cases where form-data is utf-8 encoded but
    not encoding is not explicitly specified

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maxxedev/commons-fileupload master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-fileupload/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
   
----
commit 6b3ac5aea05876e355ed3a0ecc60ab685b5d2810
Author: maxxedev <[hidden email]>
Date:   2017-10-06T18:35:34Z

    FILEUPLOAD-286: allow default charset to be overridden.
   
    useful in cases where form-data is utf-8 encoded but
    not encoding is not explicitly specified

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

kinow
Github user jochenw commented on the issue:

    https://github.com/apache/commons-fileupload/pull/10
 
    Applied.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

kinow
In reply to this post by kinow
Github user jochenw commented on the issue:

    https://github.com/apache/commons-fileupload/pull/10
 
    Applied, thank you!



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-fileupload/pull/10
 
    @maxxedev Thanks for the pull request! It would be nice if you could close it, now that @jochenw has merged it. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

kinow
In reply to this post by kinow
Github user maxxedev commented on the issue:

    https://github.com/apache/commons-fileupload/pull/10
 
    thanks for quck response and merge.
   
    not sure what's going to what's going with builds for jdk6/7.
   
    closing pull request anyways


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

kinow
In reply to this post by kinow
Github user maxxedev closed the pull request at:

    https://github.com/apache/commons-fileupload/pull/10


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-fileupload issue #10: FILEUPLOAD-286: allow default charset to be ov...

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-fileupload/pull/10
 
    @maxxedev Thanks!
   
    The jdk6/7 build failures are unrelated. https://github.com/apache/commons-fileupload/pull/11 contains the fix for these failures.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]