[GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...

kinow
Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/18#discussion_r131540224
 
    --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java ---
    @@ -248,6 +258,35 @@ public PhotoshopApp13Data parsePhotoshopSegment(final byte[] bytes,
             return elements;
         }
     
    +    private String getEncodingCharsetName(byte[] codedCharacterSet){
    +        final Character WHITESPACE = ' ';
    +        String codedCharacterSetString = new String(codedCharacterSet);
    +        try {
    +            if (Charset.isSupported(codedCharacterSetString)) {
    +                return codedCharacterSetString;
    +            }
    +        }catch (IllegalCharsetNameException e){
    +
    --- End diff --
   
    Might be worth to add at least one comment saying why these exceptions are not important, and that can be safely ignored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...