[GitHub] commons-io pull request #41: Missing Test Case for negative offset value

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-io pull request #41: Missing Test Case for negative offset value

kinow
GitHub user ileontiuc opened a pull request:

    https://github.com/apache/commons-io/pull/41

    Missing Test Case for negative offset value

    The method copyLarge(InputStream input, InputStream output, int offset, buffer) copies the content of input into output. If offset is a positive number, it will skip a number of bytes from input equal to offset value. By performing mutation testing analysis we noticed that the copyLarge method was never tested for a negative value for offset. The added test call copyLarge with a negative value and check that the behavior is the same as for offset = 0, where no bytes are skipped from input.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ileontiuc/commons-io patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #41
   
----
commit 86fb8a11d638ba385fca1a1bad4ea02d8ba0a83d
Author: Ioana Leontiuc <[hidden email]>
Date:   2017-08-02T14:09:30Z

    Missing Test Case for negative offset value
   
    The method copyLarge(InputStream input, InputStream output, int offset, buffer) copies the content of input into output. If offset is a positive number, it will skip a number of bytes from input equal to offset value. By performing mutation testing analysis we noticed that the copyLarge method was never tested for a negative value for offset. The added test call copyLarge with a negative value and check that the behavior is the same as for offset = 0, where no bytes are skipped from input.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-io pull request #41: Missing Test Case for negative offset value

kinow
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-io/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...