[GitHub] commons-io pull request #56: Removed redundant isDirectory() check

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-io pull request #56: Removed redundant isDirectory() check

garydgregory-2
GitHub user pranet opened a pull request:

    https://github.com/apache/commons-io/pull/56

    Removed redundant isDirectory() check

    There is already a call to validateListFilesParameters() which checks that directory.isDirectory() is true

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pranet/commons-io master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
   
----
commit 572839355ece71a0c8b91d75f21403142070f0cc
Author: Pranet Verma <pranetverma@...>
Date:   2018-03-08T06:24:11Z

    Removed redundant isDirectory() check

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-io pull request #56: Removed redundant isDirectory() check

garydgregory-2
Github user pranet closed the pull request at:

    https://github.com/apache/commons-io/pull/56


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-io pull request #56: Removed redundant isDirectory() check

garydgregory-2
In reply to this post by garydgregory-2
GitHub user pranet reopened a pull request:

    https://github.com/apache/commons-io/pull/56

    Removed redundant isDirectory() check

    There is already a call to validateListFilesParameters() which checks that directory.isDirectory() is true

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pranet/commons-io master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
   
----
commit 572839355ece71a0c8b91d75f21403142070f0cc
Author: Pranet Verma <pranetverma@...>
Date:   2018-03-08T06:24:11Z

    Removed redundant isDirectory() check

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-io pull request #56: Removed redundant isDirectory() check

garydgregory-2
In reply to this post by garydgregory-2
Github user pranet closed the pull request at:

    https://github.com/apache/commons-io/pull/56


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]