[GitHub] commons-io pull request #68: Output all parameters in ReversedLinesFileReade...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-io pull request #68: Output all parameters in ReversedLinesFileReade...

ttulka
GitHub user august782 opened a pull request:

    https://github.com/apache/commons-io/pull/68

    Output all parameters in ReversedLinesFileReaderTestParamFile

    In ReversedLinesFileReaderTestParamFile, the parameterized tests have three parameters, but currently the test class is configured to only output the first two. Outputting only the first two parameters is not enough to distinguish the different parameterized tests, particularly for the ones whose first two parameters are "test-file-utf8-win-linebr.bin", "UTF-8". The proposed fix is to output all three parameters as part of the reporting of the tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/august782/commons-io fix-parameterized-test-names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
   
----
commit 0b6bf96849953186b3de7cd81d3b918d1980f7db
Author: August Shi <awshi2@...>
Date:   2018-10-29T17:28:22Z

    Changing to output all parameters for parameterized tests to distinguish them

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]