[GitHub] [commons-lang] JLLeitschuh commented on a change in pull request #459: (doc): Document public RandomStringUtils exploit

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-lang] JLLeitschuh commented on a change in pull request #459: (doc): Document public RandomStringUtils exploit

GitBox
JLLeitschuh commented on a change in pull request #459: (doc): Document public RandomStringUtils exploit
URL: https://github.com/apache/commons-lang/pull/459#discussion_r325301182
 
 

 ##########
 File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
 ##########
 @@ -34,7 +34,11 @@
  * RandomStringGenerator</a> instead.</p>
  *
  * <p>Caveat: Instances of {@link Random}, upon which the implementation of this
- * class relies, are not cryptographically secure.</p>
+ * class relies, are <b>not cryptographically secure</b>.
+ * Do not use this classes' default implementation of {@link Random} in security sensitive locations,
+ * for example password reset key generation, as all future values can be computed as proven by
+ * <a href="https://medium.com/@alex91ar/the-java-soothsayer-a-practical-application-for-insecure-randomness-c67b0cd148cd?source=friends_link&sk=3db1c41cc81a58f70ed05a7315191385">
 
 Review comment:
   @alex91ar Thoughts?
   I have a CVE for JHipster. That's just a specific case though. This is a full POC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services