[GitHub] [commons-lang] chtompki commented on issue #459: (doc): Document public RandomStringUtils exploit

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-lang] chtompki commented on issue #459: (doc): Document public RandomStringUtils exploit

GitBox
chtompki commented on issue #459: (doc): Document public RandomStringUtils exploit
URL: https://github.com/apache/commons-lang/pull/459#issuecomment-532689260
 
 
   I'm still mildly confused how:
   
   https://github.com/apache/commons-lang/blob/commons-lang-3.9/src/main/java/org/apache/commons/lang3/RandomStringUtils.java#L36-L37
   
   > Caveat: Instances of [Random](https://docs.oracle.com/javase/8/docs/api/java/util/Random.html), upon which the implementation of this class relies, are not cryptographically secure.
   
   doesn't lead the reader to conclude the class is not to be used for the purpose of security and in turn minimally use `SecureRandom` (as stipulated in the `java.util.Random` javadoc, to which we've linked).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services