Quantcast

[GitHub] commons-lang pull request #253: Added a restart method for convenience

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang pull request #253: Added a restart method for convenience

asfgit
GitHub user esend7881 opened a pull request:

    https://github.com/apache/commons-lang/pull/253

    Added a restart method for convenience

    The restart function will allow lazy people like me to simple call `stopwatch.reset()` instead of manually calling the `stop`, `restart` `start` methods one by one, or recreating the object itself.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/esend7881/commons-lang master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #253
   
----
commit d6f3109985eec112acb1584d3561c04ca9a76b9b
Author: Eric K. Sender <[hidden email]>
Date:   2017-03-09T21:53:44Z

    Added a restart method for convenience
   
    The restart function will allow lazy people like me to simple call `stopwatch.reset()` instead of manually calling the `stop`, `restart` `start` methods one by one, or recreating the object itself.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #253: Added a restart method for convenience

asfgit
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/253
 
   
    [![Coverage Status](https://coveralls.io/builds/10532505/badge)](https://coveralls.io/builds/10532505)
   
    Coverage increased (+0.01%) to 94.54% when pulling **d6f3109985eec112acb1584d3561c04ca9a76b9b on esend7881:master** into **ee19f8247c4bc0335ad3efe212dc0bdce97e2034 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #253: Added a restart method for convenience

asfgit
In reply to this post by asfgit
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/253
 
   
    [![Coverage Status](https://coveralls.io/builds/10532505/badge)](https://coveralls.io/builds/10532505)
   
    Coverage increased (+0.01%) to 94.54% when pulling **d6f3109985eec112acb1584d3561c04ca9a76b9b on esend7881:master** into **ee19f8247c4bc0335ad3efe212dc0bdce97e2034 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #253: Added a restart method for convenience

asfgit
In reply to this post by asfgit
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/253
 
    Hi @esend7881
   
    thanks for the pull request.
   
    I'm not sure it is a good idea to add at method that is nearly identical to `StopWatch#createStarted`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #253: Added a restart method for convenience

asfgit
In reply to this post by asfgit
Github user esend7881 commented on the issue:

    https://github.com/apache/commons-lang/pull/253
 
    @PascalSchumacher good point. I would say the main advantage is my method would not have the JVM re-create an object. So if you are restarting the timer over and over, it may be less costly. In the end, same outcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang pull request #253: Added a restart method for convenience

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/253


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...