Quantcast

[GitHub] commons-lang pull request #261: LANG-1317: Add findAnnotation and findMethod...

classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

ecki
Github user yasserzamani commented on the issue:

    https://github.com/apache/commons-lang/pull/261
 
    @PascalSchumacher , sorry for my bad decisions. Again I thought I should keep it public to provide same functionality for someone who needs in future :)
   
    Now, I removed it to MethodUtils as a private method. I also added @since tag and mentioned interfaces in @return java doc.
   
    Thanks a lot!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

ecki
In reply to this post by ecki
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/261
 
   
    [![Coverage Status](https://coveralls.io/builds/11177727/badge)](https://coveralls.io/builds/11177727)
   
    Coverage increased (+0.09%) to 94.693% when pulling **6aee4203260f93cf4511779e8078952e90d6bb6f on yasserzamani:LANG-1317** into **4a300fee2ef1c03902d0fb25ceb02aa01d0fab46 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

ecki
In reply to this post by ecki
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/261
 
   
    [![Coverage Status](https://coveralls.io/builds/11177727/badge)](https://coveralls.io/builds/11177727)
   
    Coverage increased (+0.09%) to 94.693% when pulling **6aee4203260f93cf4511779e8078952e90d6bb6f on yasserzamani:LANG-1317** into **4a300fee2ef1c03902d0fb25ceb02aa01d0fab46 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #261: LANG-1317 Adds MethodUtils#findAnnotation and exten...

ecki
In reply to this post by ecki
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/261
 
    @yasserzamani Thanks!
   
    No need to apologize. It is just that we try to be conservative with new additions (If we add a public method we have to support it for a long time and can not do any incompatible changes.). If the method is deemed generally useful it can always be moved and made public later on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang pull request #261: LANG-1317 Adds MethodUtils#findAnnotation an...

ecki
In reply to this post by ecki
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-lang issue #261: LANG-1317 Adds MethodUtils#findAnnotation and exten...

ecki
In reply to this post by ecki
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/261
 
    Merged. Thank you very much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12
Loading...