[GitHub] commons-lang pull request #299: Add module-info for Java 9

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #299: Add module-info for Java 9

kinow
GitHub user jodastephen opened a pull request:

    https://github.com/apache/commons-lang/pull/299

    Add module-info for Java 9

    Add the module-info.java file
    Make the appropriate changes to pom.xml

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jodastephen/commons-lang module-info

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #299
   
----
commit 8f5aeed9db2ec0fed0e81ebd24a9608d0d4d68d6
Author: Stephen Colebourne <[hidden email]>
Date:   2017-10-10T16:56:41Z

    Add module-info for Java 9
   
    Add the module-info.java file
    Make the appropriate changes to pom.xml

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #299: Add module-info for Java 9

kinow
Github user britter commented on the issue:

    https://github.com/apache/commons-lang/pull/299
 
    Awesome! Would be create if you could create and reference a JIRA ticket as described in CONTRIBUTING.md, so this will show up in our release notes.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user stokito commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/299#discussion_r143869192
 
    --- Diff: .travis.yml ---
    @@ -17,12 +17,10 @@ language: java
     sudo: false
     
     jdk:
    -  - openjdk7
    --- End diff --
   
    Why did you removed the build for jdk7 and 8?
    If lang3 still support them then it should be runned tests on 7 and 8


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user jodastephen commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/299#discussion_r144119796
 
    --- Diff: .travis.yml ---
    @@ -17,12 +17,10 @@ language: java
     sudo: false
     
     jdk:
    -  - openjdk7
    --- End diff --
   
    With the proposed change, the build can only occur on Java 9. (Java 9 is needed to compile `module-info.java`).


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user stokito commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/299#discussion_r144134867
 
    --- Diff: .travis.yml ---
    @@ -17,12 +17,10 @@ language: java
     sudo: false
     
     jdk:
    -  - openjdk7
    --- End diff --
   
    Sounds sad :( Especially because, I guess, jdk8 compiler willn't just ignore the `module-info.java`.
    Maybe some other projects will even try to generate the `module-info.java`


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user britter commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/299#discussion_r144693421
 
    --- Diff: .travis.yml ---
    @@ -17,12 +17,10 @@ language: java
     sudo: false
     
     jdk:
    -  - openjdk7
    --- End diff --
   
    I think we should discuss this on the developer mailing list.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/299
 
   
    [![Coverage Status](https://coveralls.io/builds/13758874/badge)](https://coveralls.io/builds/13758874)
   
    Coverage increased (+0.01%) to 95.199% when pulling **cb5a17949bf941118a80ef05ccd5a77717779792 on jodastephen:module-info** into **1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/299
 
   
    [![Coverage Status](https://coveralls.io/builds/13771246/badge)](https://coveralls.io/builds/13771246)
   
    Coverage increased (+0.01%) to 95.199% when pulling **07c0c408e72836231ef262f565761778e3e9e103 on jodastephen:module-info** into **1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #299: Add module-info for Java 9

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/299
 
   
    [![Coverage Status](https://coveralls.io/builds/13771842/badge)](https://coveralls.io/builds/13771842)
   
    Coverage increased (+0.01%) to 95.199% when pulling **886b26aa09efc1a4bfca3470e33b952399f18f6d on jodastephen:module-info** into **1f0dfc31b51a445eb2cfbee5321800cf51e10b67 on apache:master**.



---