[GitHub] commons-lang pull request #381: LANG-1406 StringIndexOutOfBoundsException in...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #381: LANG-1406 StringIndexOutOfBoundsException in...

Turan91
GitHub user drajakumar opened a pull request:

    https://github.com/apache/commons-lang/pull/381

    LANG-1406 StringIndexOutOfBoundsException in StringUtils.replaceIgnor…

    …eCase

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/drajakumar/commons-lang master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #381
   
----
commit 77ad336da790dc522216300bfb20d74b779a9d62
Author: Don Jeba <donjeba@...>
Date:   2018-11-15T19:31:23Z

    LANG-1406 StringIndexOutOfBoundsException in StringUtils.replaceIgnoreCase

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #381: LANG-1406 StringIndexOutOfBoundsException in String...

Turan91
Github user drajakumar commented on the issue:

    https://github.com/apache/commons-lang/pull/381
 
    @kinow can you kindly review and comment whether this fix holds good, thank you!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #381: LANG-1406 StringIndexOutOfBoundsException in String...

Turan91
In reply to this post by Turan91
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/381
 
   
    [![Coverage Status](https://coveralls.io/builds/20129896/badge)](https://coveralls.io/builds/20129896)
   
    Coverage increased (+0.002%) to 95.235% when pulling **77ad336da790dc522216300bfb20d74b779a9d62 on drajakumar:master** into **c4d0dbcb56b8980b1b3b7c85d00ad6540788c08e on apache:master**.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #381: LANG-1406 StringIndexOutOfBoundsException in String...

Turan91
In reply to this post by Turan91
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/381
 
    @kinow What do you think is this a better solution than #340?


---