[GitHub] commons-lang pull request #390: Adding junits for StandardToStringStyle

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #390: Adding junits for StandardToStringStyle

Turan91
GitHub user RahulNagekar opened a pull request:

    https://github.com/apache/commons-lang/pull/390

    Adding junits for StandardToStringStyle

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RahulNagekar/commons-lang StandardToStringStyle_Junits

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #390
   
----
commit 727cf95fd218a00b8a27927a38ab5d6c2952840e
Author: RahulNagekar <rahul.nagekar1@...>
Date:   2018-11-28T19:54:43Z

    Adding junits for StandardToStringStyle

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

Turan91
Github user coveralls commented on the issue:

    https://github.com/apache/commons-lang/pull/390
 
   
    [![Coverage Status](https://coveralls.io/builds/20344775/badge)](https://coveralls.io/builds/20344775)
   
    Coverage increased (+0.04%) to 95.273% when pulling **1af042036ba852b9099dc5e560388dc41b708a7e on RahulNagekar:StandardToStringStyle_Junits** into **aae1a0a681a8aca3a9c200c3b1b61299cee2f811 on apache:master**.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

Turan91
In reply to this post by Turan91
Github user RahulNagekar commented on the issue:

    https://github.com/apache/commons-lang/pull/390
 
    This is my entry level checkin just to understand flow here, will get into more contribution once this is merged/accepted.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

Turan91
In reply to this post by Turan91
Github user RahulNagekar commented on the issue:

    https://github.com/apache/commons-lang/pull/390
 
    @garydgregory Any references on how can I ask for a review or get into contribution.
   
    I am new to open source so.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

Turan91
In reply to this post by Turan91
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/390
 
    Thank for the contribution.
   
    Could you please squash to the commits? Then I will merge the pull request.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

Turan91
In reply to this post by Turan91
Github user RahulNagekar commented on the issue:

    https://github.com/apache/commons-lang/pull/390
 
    > Thank for the contribution.
    >
    > Could you please squash to the commits? Then I will merge the pull request.
   
    Done :-)


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #390: Adding junits for StandardToStringStyle

Turan91
In reply to this post by Turan91
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/390


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang issue #390: Adding junits for StandardToStringStyle

Turan91
In reply to this post by Turan91
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/390
 
    Thanks!


---