[GitHub] commons-lang pull request #392: LANG-1410: eliminate one unnecessary local i...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #392: LANG-1410: eliminate one unnecessary local i...

Turan91
GitHub user rosti-il opened a pull request:

    https://github.com/apache/commons-lang/pull/392

    LANG-1410: eliminate one unnecessary local int variable and add more tests

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rosti-il/commons-lang LANG-1410

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #392
   
----
commit 85ad50c5ed73d257c465bdbbd3da792768db3993
Author: Rostislav Krasny <rostigm@...>
Date:   2018-12-08T00:14:35Z

    LANG-1410: eliminate one unnecessary local int variable and add more tests

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #392: LANG-1410: eliminate one unnecessary local i...

Turan91
Github user asciborek commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/392#discussion_r241740720
 
    --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
    @@ -338,15 +338,17 @@ public static boolean isAllEmpty(final CharSequence... css) {
          * @since 3.0 Changed signature from isBlank(String) to isBlank(CharSequence)
          */
         public static boolean isBlank(final CharSequence cs) {
    -        int strLen;
    --- End diff --
   
    I think that name strLen is more informative


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-lang pull request #392: LANG-1410: eliminate one unnecessary local i...

Turan91
In reply to this post by Turan91
Github user rosti-il commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/392#discussion_r241744790
 
    --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java ---
    @@ -338,15 +338,17 @@ public static boolean isAllEmpty(final CharSequence... css) {
          * @since 3.0 Changed signature from isBlank(String) to isBlank(CharSequence)
          */
         public static boolean isBlank(final CharSequence cs) {
    -        int strLen;
    --- End diff --
   
    Maybe, however 'strLen' sounds like something unchangeable, since String is immutable in Java. I've chosen this variable name to be the same to name of the similar 'sz' variable in isWhitespace() method. The 'sz' name stands for "size", I think. If we decide to change it we should change names of they both.


---