[GitHub] [commons-lang] verhas commented on a change in pull request #470: Boolean utils limited cleanup

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-lang] verhas commented on a change in pull request #470: Boolean utils limited cleanup

GitBox
verhas commented on a change in pull request #470: Boolean utils limited cleanup
URL: https://github.com/apache/commons-lang/pull/470#discussion_r344069803
 
 

 ##########
 File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
 ##########
 @@ -4609,17 +4609,8 @@ public static int lastIndexOf(final short[] array, final short valueToFind, int
      * (index < 0 || index >= array.length), or if the array is {@code null}.
      * @since 2.1
      */
-    public static boolean[] toPrimitive(final Boolean[] array) {
 
 Review comment:
   I think you were looking at some outdated version of the request.
   
   This method starts on the line 8886 in the current pull request and also on the current master.
   
   The other possibility that I am totally missing something. One thing is for sure: I would never intentionally suggest the deletion or change of an API method.
   
   Could you have a look at it again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services