[GitHub] [commons-rng] aherbert commented on issue #61: RNG-85: Middle Square Weyl Sequence generator

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-rng] aherbert commented on issue #61: RNG-85: Middle Square Weyl Sequence generator

GitBox
aherbert commented on issue #61: RNG-85: Middle Square Weyl Sequence generator
URL: https://github.com/apache/commons-rng/pull/61#issuecomment-523616733
 
 
   @cawatson Thanks for your interest in developing tools to automate testing. I assume you have targeted these methods as they have no `Assert` statements. However one method uses a custom assertion class for the test, the other exercises a constructor code path to ensure an exception is not thrown. Both are valid tests without further assertions.
   
   The assert statements you have suggested are not valid. The first will fail since the seed is not defined to be all zeros. The seed is part of the test input data and should not be targeted with an assertion. The second assert statements are incomplete as they refer to `position` and `group` which do not exist and so require a definition. In the final case in general `assertTrue(x == 0)` should be replaced with `assertEquals(0, x)`.
   
   Since this is a closed PR this is not a suitable forum. I suggest you seek feedback on the developers mailing list `[hidden email]` using the `[rng]` subject prefix for this component.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services