[GitHub] commons-rng pull request #13: RNG-61: Remove unnecessary conditional from in...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng pull request #13: RNG-61: Remove unnecessary conditional from in...

RahulNagekar
GitHub user aherbert opened a pull request:

    https://github.com/apache/commons-rng/pull/13

    RNG-61: Remove unnecessary conditional from inside shuffle loop

    I have also updated the constructor exception messages to be clearer on what has failed and added a Javadoc link to a definition of Permutation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aherbert/commons-rng improvement-RNG-61

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-rng/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
   
----
commit d3ac7f75e2ed7e21fc48c5db8c5ea8bfbe3533f3
Author: Alex Herbert <a.herbert@...>
Date:   2018-11-19T08:54:17Z

    RNG-61: Remove unnecessary conditional from inside shuffle loop

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng issue #13: RNG-61: Remove unnecessary conditional from inside sh...

RahulNagekar
Github user coveralls commented on the issue:

    https://github.com/apache/commons-rng/pull/13
 
   
    [![Coverage Status](https://coveralls.io/builds/20175287/badge)](https://coveralls.io/builds/20175287)
   
    Coverage increased (+0.009%) to 97.552% when pulling **d3ac7f75e2ed7e21fc48c5db8c5ea8bfbe3533f3 on aherbert:improvement-RNG-61** into **0fdcd9007c708aa48f1989cb2211ea56c1fcd702 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng pull request #13: RNG-61: Remove unnecessary conditional from in...

RahulNagekar
In reply to this post by RahulNagekar
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-rng/pull/13


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]