[GitHub] commons-rng pull request #14: fix: removed 1.8 annotation to ensure 1.7 comp...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng pull request #14: fix: removed 1.8 annotation to ensure 1.7 comp...

Turan91
GitHub user aherbert opened a pull request:

    https://github.com/apache/commons-rng/pull/14

    fix: removed 1.8 annotation to ensure 1.7 compliance

    Noticed this JDK 1.8 annotation when compiling on a machine with Open JDK 1.7 (it broke).
   
    The pom.xml for commons-rng-examples uses 1.7 as the compliance level so this should be removed. The interface is not used with Lambda expressions anyway, i.e. the annotation should not be there.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aherbert/commons-rng fix-jmh-java-version-1.7-compliance

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-rng/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
   
----
commit 6dca4630fb4df34eb5e106dfbbe66bff271526ee
Author: aherbert <a.herbert@...>
Date:   2018-11-19T15:11:59Z

    fix: removed 1.8 annotation to ensure 1.7 compliance

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng issue #14: fix: removed 1.8 annotation to ensure 1.7 compliance

Turan91
Github user coveralls commented on the issue:

    https://github.com/apache/commons-rng/pull/14
 
   
    [![Coverage Status](https://coveralls.io/builds/20181767/badge)](https://coveralls.io/builds/20181767)
   
    Coverage remained the same at 97.544% when pulling **6dca4630fb4df34eb5e106dfbbe66bff271526ee on aherbert:fix-jmh-java-version-1.7-compliance** into **0fdcd9007c708aa48f1989cb2211ea56c1fcd702 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng issue #14: fix: removed 1.8 annotation to ensure 1.7 compliance

Turan91
In reply to this post by Turan91
Github user coveralls commented on the issue:

    https://github.com/apache/commons-rng/pull/14
 
   
    [![Coverage Status](https://coveralls.io/builds/20181767/badge)](https://coveralls.io/builds/20181767)
   
    Coverage remained the same at 97.544% when pulling **6dca4630fb4df34eb5e106dfbbe66bff271526ee on aherbert:fix-jmh-java-version-1.7-compliance** into **0fdcd9007c708aa48f1989cb2211ea56c1fcd702 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-rng pull request #14: fix: removed 1.8 annotation to ensure 1.7 comp...

Turan91
In reply to this post by Turan91
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-rng/pull/14


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]