[GitHub] [commons-statistics] aherbert commented on a change in pull request #14: [Statistics-7] Descriptive module. This package provides descriptive statistics of data for example mean, variance and moments.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [commons-statistics] aherbert commented on a change in pull request #14: [Statistics-7] Descriptive module. This package provides descriptive statistics of data for example mean, variance and moments.

GitBox
aherbert commented on a change in pull request #14: [Statistics-7] Descriptive module. This package provides descriptive statistics of data for example mean, variance and moments.
URL: https://github.com/apache/commons-statistics/pull/14#discussion_r287466527
 
 

 ##########
 File path: commons-statistics-descriptive/pom.xml
 ##########
 @@ -0,0 +1,43 @@
+<?xml version="1.0"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.commons</groupId>
+    <artifactId>commons-statistics-parent</artifactId>
+    <version>0.1-SNAPSHOT</version>
+  </parent>
+  <groupId>org.apache.commons</groupId>
+  <artifactId>commons-statistics-descriptive</artifactId>
+  <version>0.1-SNAPSHOT</version>
+  <name>Apache Commons Statistics Descriptive</name>
+  <description>Descriptive/Summary Statistics.</description>
+
+  <properties>
+    <!-- This value must reflect the current name of the base package. -->
+    <commons.osgi.symbolicName>org.apache.commons.statistics.descriptive</commons.osgi.symbolicName>
+    <!-- OSGi -->
+    <commons.osgi.export>org.apache.commons.statistics.descriptive</commons.osgi.export>
+    <!-- Workaround to avoid duplicating config files. -->
+    <statistics.parent.dir>${basedir}/..</statistics.parent.dir>
+    <maven.javadoc.skip>true</maven.javadoc.skip>
 
 Review comment:
   You did not add a TODO comment to remove this in the future.
   
   Plus you have a few extra blank lines below the end of the properties tag. Otherwise it looks good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services