[GitHub] commons-text pull request #48: TEXT-88: Fixed issue with empty delimiters ar...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #48: TEXT-88: Fixed issue with empty delimiters ar...

mureinik
GitHub user ameyjadiye opened a pull request:

    https://github.com/apache/commons-text/pull/48

    TEXT-88: Fixed issue with empty delimiters array with capitalizeFully

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ameyjadiye/commons-text TEXT-88

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
   
----
commit 0dd69e060be13c596316e878da2c3591b722c015
Author: Amey Jadiye <[hidden email]>
Date:   2017-06-12T17:56:46Z

    TEXT-88: Fixed issue with empty delimiters array with capitalizeFully

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
Github user arunvinudss commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
    @ameyjadiye The agreed upon fix as of now should be:
   
    WordUtils.capitalizeFully("i am fine", new char[]{})  --> I am fine
   
    We shouldn't take space as the delimiter as the user explicitly passes an empty array for delimiter . Anyways we are still discussing on that and I guess you can make the required changes once we have an agreement on this .
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
In reply to this post by mureinik
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
   
    [![Coverage Status](https://coveralls.io/builds/12224670/badge)](https://coveralls.io/builds/12224670)
   
    Coverage decreased (-0.002%) to 97.302% when pulling **3f5dfd4b1cc24fa31446a9ea5821cf267375e552 on ameyjadiye:TEXT-88** into **5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
In reply to this post by mureinik
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
    I think we are good to merge this as per discussion here [TEXT-88](https://issues.apache.org/jira/browse/TEXT-88)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
In reply to this post by mureinik
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
   
    [![Coverage Status](https://coveralls.io/builds/12236812/badge)](https://coveralls.io/builds/12236812)
   
    Coverage decreased (-0.002%) to 97.302% when pulling **6323af50bb751a725ab47545c95572703fe1310d on ameyjadiye:TEXT-88** into **5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
In reply to this post by mureinik
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
   
    [![Coverage Status](https://coveralls.io/builds/12236812/badge)](https://coveralls.io/builds/12236812)
   
    Coverage decreased (-0.002%) to 97.302% when pulling **6323af50bb751a725ab47545c95572703fe1310d on ameyjadiye:TEXT-88** into **5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
In reply to this post by mureinik
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
    Should we add to `public static boolean isDelimiter(final char ch, final char[] delimiters)` or `isDelimiter` generally, documentation stating that if an empty array is passed in we always return false?
   
    I'm torn on this. What are your thoughts @ameyjadiye?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

mureinik
In reply to this post by mureinik
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-text/pull/48
 
    ```isDelimiter``` is simply the method to identify if codePoint or char is present in given second parameter which is array. ofcource if array is empty it means first param is not present in array and should return false, I think overall behaviour of ```capitalizeFully```  is correct now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #48: TEXT-88: Fixed issue with empty delimiters ar...

mureinik
In reply to this post by mureinik
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-text/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...