[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

kinow
GitHub user ameyjadiye opened a pull request:

    https://github.com/apache/commons-text/pull/61

    Added flexible Travis-ci  build script.

    This enables ua to use any jdk against our code and not keeps us dependency on Travis to provide jdk

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ameyjadiye/commons-text travis-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
   
----
commit 4af7ca425032c40ba71e23da0664d38a2d307576
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T14:49:17Z

    added jacoco style travis build

commit 2bd09c827b2b1297b6b8fd4c85a7d4587b7bb1da
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T14:55:11Z

    modified permission to executable file

commit 935be51655f57dcefe2ffd7dc15758cd12cc3047
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T15:00:47Z

    removed java6 option

commit cba4a1e8740f60c760d31f501882f539b3cca055
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T18:30:17Z

    added ibm java 8

commit f8fc754cedb19dd28e90a5673944d2a024356368
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T18:55:55Z

    print system info

commit 4147b1bc07c4863bec07f3f4fcc8d04fe91281e8
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T19:17:43Z

    install ibmjdk8 to ./

commit 796cc3a927c757aae15bd8710ad32c56387273fc
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-29T19:22:05Z

    install ibmjdk8 to ./

commit 8827c044cf237b7a95d53d61cbc62a01e80639c9
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-30T11:22:17Z

    check space on travis box

commit 111678e8679ec8d3fa73ebaf93b74a29eccdfd88
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-30T11:27:04Z

    use trusty for build

commit e92323096cfd3fed7e0980144b31f98575fdd387
Author: Amey Jadiye <[hidden email]>
Date:   2017-07-30T11:39:06Z

    back to precise plus sudo truewq

commit 44c36828b5b335ee1df09d28a477ab9c88079157
Author: Amey Jadiye <[hidden email]>
Date:   2017-08-01T19:28:34Z

    using 64 bit edition

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/61
 
    I'll get to this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/61
 
    In my opinion this is overkill. I don't think commons-text needs to be tested against the eclipse java compiler and early access version of java 8 and 9. The script looks difficult to debug and maintain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/61
 
    Personally I'm a +0 to +1 on this, but @PascalSchumacher has a very valid point. I try to subscribe to the thought that there should be a high bar to sacrificing simplicity. So, with that in mind, should we take this up to the dev list to get other folks opinions? That work for you guys?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/61
 
    +1 for moving this discussion to the mailing list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/61
 
    Also note that currently this script only compiles and runs test.  Rat, clirr, findbugs and javadoc are not executed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/61#discussion_r130977723
 
    --- Diff: pom.xml ---
    @@ -171,6 +171,7 @@
                   <exclude>src/site/resources/download_lang.cgi</exclude>
                   <exclude>src/test/resources/stringEscapeUtilsTestData.txt</exclude>
                   <exclude>src/site/resources/release-notes/RELEASE-NOTES-*.txt</exclude>
    +              <exclude>.travis.sh</exclude>
    --- End diff --
   
    You could put an Apache License comment at the top of this file because it accommodates comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user ameyjadiye commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/61#discussion_r130978503
 
    --- Diff: pom.xml ---
    @@ -171,6 +171,7 @@
                   <exclude>src/site/resources/download_lang.cgi</exclude>
                   <exclude>src/test/resources/stringEscapeUtilsTestData.txt</exclude>
                   <exclude>src/site/resources/release-notes/RELEASE-NOTES-*.txt</exclude>
    +              <exclude>.travis.sh</exclude>
    --- End diff --
   
    Sure, this was quick fix ;-) ... one more thing, do we need consent from jacoco using and modifying their file ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/61#discussion_r130979086
 
    --- Diff: pom.xml ---
    @@ -171,6 +171,7 @@
                   <exclude>src/site/resources/download_lang.cgi</exclude>
                   <exclude>src/test/resources/stringEscapeUtilsTestData.txt</exclude>
                   <exclude>src/site/resources/release-notes/RELEASE-NOTES-*.txt</exclude>
    +              <exclude>.travis.sh</exclude>
    --- End diff --
   
    It looks like, with a quick read of their License.md, that we would minimally need to include their license at the end of ours, but I would have to defer to others for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user ameyjadiye commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/61#discussion_r131239555
 
    --- Diff: pom.xml ---
    @@ -171,6 +171,7 @@
                   <exclude>src/site/resources/download_lang.cgi</exclude>
                   <exclude>src/test/resources/stringEscapeUtilsTestData.txt</exclude>
                   <exclude>src/site/resources/release-notes/RELEASE-NOTES-*.txt</exclude>
    +              <exclude>.travis.sh</exclude>
    --- End diff --
   
    which part of their license shall I add ? content of their ```License.md``` ? seems like they distribut code with eclipse license.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user ameyjadiye commented on the issue:

    https://github.com/apache/commons-text/pull/61
 
    Because of low interest of community adapting this change i'm closing this pull request.
   
    http://markmail.org/message/mn2or73hqsz6oxo2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

kinow
In reply to this post by kinow
Github user ameyjadiye closed the pull request at:

    https://github.com/apache/commons-text/pull/61


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...