[GitHub] commons-text pull request #64: Minor JavaDoc change for deprecated isDelimit...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text pull request #64: Minor JavaDoc change for deprecated isDelimit...

testingsavvy
GitHub user arunvinudss opened a pull request:

    https://github.com/apache/commons-text/pull/64

    Minor JavaDoc change for deprecated isDelimiter

    @chtompki Please review and merge.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arunvinudss/commons-text editJavaDocs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
   
----
commit f972a5b87f57ac93476bf31f0e2bacdc40f751ba
Author: Arun Vinud <[hidden email]>
Date:   2017-09-24T13:36:16Z

    Minor JavaDoc change for deprecated isDelimiter

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

testingsavvy
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/64
 
   
    [![Coverage Status](https://coveralls.io/builds/13407041/badge)](https://coveralls.io/builds/13407041)
   
    Coverage remained the same at 98.236% when pulling **f972a5b87f57ac93476bf31f0e2bacdc40f751ba on arunvinudss:editJavaDocs** into **3bb08232fe080f6e421d51a0856d77ce44ea2e2a on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

testingsavvy
In reply to this post by testingsavvy
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/64
 
    Thanks for the pull request.
   
    Imho we should make it absolutely clear that users should not use this method. Therefore I'm against making the formulation "softer".


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

testingsavvy
In reply to this post by testingsavvy
Github user arunvinudss commented on the issue:

    https://github.com/apache/commons-text/pull/64
 
    Hey @PascalSchumacher! In my understanding we didn't make a decision yet. A part of the reason is that it was exposed as a public method and since consumers would potentially lose a functionality we wanted to convey our intentions in a more smoother way and at the same time making our intentions clear. I would like to hear others views on this before we make a decision though.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

testingsavvy
In reply to this post by testingsavvy
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/64
 
    @arunvinudss - would you vote for removing it if we were to roll a, very hypothetical, 2.0 right now? If so, then I'd say we have our decision.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

testingsavvy
In reply to this post by testingsavvy
Github user arunvinudss commented on the issue:

    https://github.com/apache/commons-text/pull/64
 
    @chtompki Yes Rob I would definitely vote in the affirmative. Since the functionality provided by that method is trivial I would be surprised if anyone was using it in the first place.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

testingsavvy
In reply to this post by testingsavvy
Github user arunvinudss commented on the issue:

    https://github.com/apache/commons-text/pull/64
 
    @chtompki Closing this as we decided to remove it in 2.0. Thanks for the input @PascalSchumacher !


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text pull request #64: Minor JavaDoc change for deprecated isDelimit...

testingsavvy
In reply to this post by testingsavvy
Github user arunvinudss closed the pull request at:

    https://github.com/apache/commons-text/pull/64


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]