[GitHub] commons-text pull request #68: TEXT-74 Introduced new StrSubstitutor attribu...

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text pull request #68: TEXT-74 Introduced new StrSubstitutor attribu...

testingsavvy
GitHub user sermojohn opened a pull request:

    https://github.com/apache/commons-text/pull/68

    TEXT-74 Introduced new StrSubstitutor attribute to disable recursive substitution

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sermojohn/commons-text TEXT-74

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
   
----
commit a25aa337f08e8cd0baad1d70565552c7dad91d5b
Author: Ioannis Sermetziadis <[hidden email]>
Date:   2017-10-07T21:34:06Z

    TEXT-74 Added attribute for disabling the recursive substitution of variable values

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    Thanks for the pull request!
   
    It would be nice if you could fix the checkstyle violations. See https://travis-ci.org/apache/commons-text/jobs/284821493 for details or run "mvn checkstyle:check" locally.
   
    Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
   
    [![Coverage Status](https://coveralls.io/builds/13620504/badge)](https://coveralls.io/builds/13620504)
   
    Coverage increased (+0.003%) to 98.239% when pulling **5bd02a5f8ec870c27bc8995e7ada90997c142144 on sermojohn:TEXT-74** into **317ae8452bb616d4dcbdd9b9d561d8daf2bb5260 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user sermojohn commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    Thank you for the notice!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    Thanks!
   
    Imho this pull request is good to merge. Only thing that is missing are `@since 1.2` tags in the javadoc of the new methods.
   
    @chtompki What do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
   
    [![Coverage Status](https://coveralls.io/builds/13640479/badge)](https://coveralls.io/builds/13640479)
   
    Coverage increased (+0.003%) to 98.239% when pulling **635cb80d1cb0d32fddfe86be75b0a30eb3d3fab7 on sermojohn:TEXT-74** into **317ae8452bb616d4dcbdd9b9d561d8daf2bb5260 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
   
    [![Coverage Status](https://coveralls.io/builds/13640479/badge)](https://coveralls.io/builds/13640479)
   
    Coverage increased (+0.003%) to 98.239% when pulling **635cb80d1cb0d32fddfe86be75b0a30eb3d3fab7 on sermojohn:TEXT-74** into **317ae8452bb616d4dcbdd9b9d561d8daf2bb5260 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    Seems reasonable to me.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    Do we want it to be off by default?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user sermojohn commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    For backwards compatibility, it needs to be off by default, so recursive substitution applies by default.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text pull request #68: TEXT-74 Introduced new StrSubstitutor attribu...

testingsavvy
In reply to this post by testingsavvy
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-text/pull/68


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #68: TEXT-74 Introduced new StrSubstitutor attribute to d...

testingsavvy
In reply to this post by testingsavvy
Github user arend-von-reinersdorff commented on the issue:

    https://github.com/apache/commons-text/pull/68
 
    @sermojohn Great, thanks :-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]