[GitHub] commons-text pull request #69: Fix typos, minor clean ups

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text pull request #69: Fix typos, minor clean ups

kinow
GitHub user Abrasha opened a pull request:

    https://github.com/apache/commons-text/pull/69

    Fix typos, minor clean ups

    - simplify `if` condition with direct return
    - fix some typos
   
    Also I found a typo in public signature in `org.apache.commons.text.similarity.LongestCommonSubsequence#logestCommonSubsequence`:
   
        public CharSequence logestCommonSubsequence(final CharSequence left, final CharSequence right)
   
    This one should be
   
        public CharSequence longestCommonSubsequence(final CharSequence left, final CharSequence right)
   
    I did not touch it because it is public signature

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Abrasha/commons-text fix/code-clean-up

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-text/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #69
   
----
commit 3847951bfc40f98d3d385eb004c1d903552ad294
Author: abrasha <[hidden email]>
Date:   2017-10-12T13:44:47Z

    - fix some typos
    - simplify `if` condition with direct return

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #69: Fix typos, minor clean ups

kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/69
 
   
    [![Coverage Status](https://coveralls.io/builds/13688228/badge)](https://coveralls.io/builds/13688228)
   
    Coverage decreased (-0.001%) to 98.238% when pulling **3847951bfc40f98d3d385eb004c1d903552ad294 on Abrasha:fix/code-clean-up** into **f905725430c7f39fcc5489987506c4383dba71f0 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #69: Fix typos, minor clean ups

kinow
In reply to this post by kinow
Github user coveralls commented on the issue:

    https://github.com/apache/commons-text/pull/69
 
   
    [![Coverage Status](https://coveralls.io/builds/13688228/badge)](https://coveralls.io/builds/13688228)
   
    Coverage decreased (-0.001%) to 98.238% when pulling **3847951bfc40f98d3d385eb004c1d903552ad294 on Abrasha:fix/code-clean-up** into **f905725430c7f39fcc5489987506c4383dba71f0 on apache:master**.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #69: Fix typos, minor clean ups

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/69
 
    Thanks! 👍
   
    Concerning the typo in `org.apache.commons.text.similarity.LongestCommonSubsequence#logestCommonSubsequence`.
   
    If you like, you can submit a new pull request which marks this method as deprecated adds a new method with the correct spelling instead.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text pull request #69: Fix typos, minor clean ups

kinow
In reply to this post by kinow
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-text/pull/69


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #69: Fix typos, minor clean ups

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/69
 
    created https://issues.apache.org/jira/browse/TEXT-105 for the typo in `LongestCommonSubsequence#logestCommonSubsequence`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] commons-text issue #69: Fix typos, minor clean ups

kinow
In reply to this post by kinow
Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-text/pull/69
 
    typo issue fixed in: https://github.com/apache/commons-text/commit/804e4599bd63e4bb14c905613711eac8829e54fb
   
    Thanks again for reporting!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]