[GitHub] kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.

GitBox
kinow commented on issue #395: Replaces the given String, with the String which is nested in between two Strings.
URL: https://github.com/apache/commons-lang/pull/395#issuecomment-454675700
 
 
   I am not sure if this belongs to commons-lang. It has a practical use, and I can see you put some effort to document it and write some tests (thanks for that). But being a low level library, I feel like this would be a very simplistic template engine.
   
   Don't have time to create a working example, but I suspect I could do that with Apache Commons JEXL, Apache Velocity, or another complete template engine.
   
   This looks more related to Apache Commons Text (plus `StringUtils` is quite bloated too), but I would still keep the argument above before merging it into [text]. The replacement part can be done with `StrSubstitutor` from text. The iteration part, that creates multiple `<td>` entries... well, that part I am not sure if we have in Commons Lang or Text something similar.
   
   Anyway, if others still want to merge this new feature, it might be a good idea to drop an e-mail to the mailing list to see what others think.
   
   Cheers
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services