[GitHub] kinow opened a new pull request #40: IMAGING-220: replace while by if in the JPEG decoder extend method

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] kinow opened a new pull request #40: IMAGING-220: replace while by if in the JPEG decoder extend method

GitBox
kinow opened a new pull request #40: IMAGING-220: replace while by if in the JPEG decoder extend method
URL: https://github.com/apache/commons-imaging/pull/40
 
 
   Looking at the specification and other implementations (see JIRA ticket for links), it appears to me that the `while` in the `extend` method is actually supposed to be an `if`.
   
   All tests passing after this change, also added an extra test to validate an existing bug found by Guido Vranken, where the decoder would take longer than 10 seconds to process the file. This issue does not apply to Sanselan, only to Commons Imaging.
   
   Will merge in the next days if there are no objections.
   
   Cheers
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]