[GitHub] mureinik opened a new pull request #404: Assertion cleanup

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] mureinik opened a new pull request #404: Assertion cleanup

GitBox
mureinik opened a new pull request #404: Assertion cleanup
URL: https://github.com/apache/commons-lang/pull/404
 
 
   Use JUnit features to clean up the assertions in the test so they are easier to read and maintain, and to produce better failure messages in case an assertion fails:
   
   - `assertArraysEqual(x, y)` was used to replace `assertTrue(Arrays.equals(x, y))`
   - `assertEquals(x, y)` was used to replace `assertTrue(x == y)`
   - `assertNotEquals(x, y)` was used to replace `assertFalse(x == y)`
   - Assertions in `FunctionsTest` were rewritten to use `assertThrows` instead of the boilerplate template of throwing an exception in a `try` block, `fail`ing after that statement to make sure the exception was thrown and asserting the properties of the exception in the `catch` block.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services