[GitHub] rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX

GitBox
rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91#discussion_r255215438
 
 

 ##########
 File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c
 ##########
 @@ -41,7 +41,10 @@
 #ifdef UNIX
 static unsigned long (*dlsym_SSLeay) (void);
 static char * (*dlsym_SSLeay_version) (int);
-static void *openssl;
+static unsigned long (*dlsym_OpenSSL_version_num) (void);
+static char * (*dlsym_OpenSSL_version) (int);
+static void *openssl_old, *openssl_new;
 
 Review comment:
   I am not a big fan of *_old and *_new - can you choose more descriptive variables names?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]