[GitHub] rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX

GitBox
rhenwood-arm commented on a change in pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX
URL: https://github.com/apache/commons-crypto/pull/91#discussion_r255216439
 
 

 ##########
 File path: lib/include/config.h
 ##########
 @@ -24,7 +24,8 @@
 #elif defined(MAC_OS)
     #define COMMONS_CRYPTO_OPENSSL_LIBRARY "libcrypto.dylib"
 #else
-    #define COMMONS_CRYPTO_OPENSSL_LIBRARY "libcrypto.so"
+    #define COMMONS_CRYPTO_OPENSSL_LIBRARY "libcrypto.so.1.0.0"
+    #define COMMONS_CRYPTO_OPENSSL_LIBRARY_1 "libcrypto.so.1.1"
 
 Review comment:
   I think I would be happier with COMMONS_CRYPTO_OPENSSL_LIBRARY_1_0 and   COMMONS_CRYPTO_OPENSSL_LIBRARY_1_0
   
   thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]