[GitHub] vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

GitBox
vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-451254190
 
 
   If you use runtime checks, you don't need to touch the build at all. The same JNI library should work everywhere. If you test on a 1.1 system, it should cover everything (since Travis here will test your changes on a 1.0.2 system).
   
   If you use compile-time checks ("ifdefs"), then you need to build different libraries, which is why I prefer the approach above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

Alex Remily
Thanks again.  I'll have a go at it.

On Thu, Jan 3, 2019 at 2:40 PM GitBox <[hidden email]> wrote:

> vanzin commented on issue #92: OpenSSL 1.1.0 updates with backward
> compatibility for OpenSSL 1.0.2 and 1.0.1
> URL:
> https://github.com/apache/commons-crypto/pull/92#issuecomment-451254190
>
>
>    If you use runtime checks, you don't need to touch the build at all.
> The same JNI library should work everywhere. If you test on a 1.1 system,
> it should cover everything (since Travis here will test your changes on a
> 1.0.2 system).
>
>    If you use compile-time checks ("ifdefs"), then you need to build
> different libraries, which is why I prefer the approach above.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
> With regards,
> Apache Git Services
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>