JSVC bug or developer oversight?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

JSVC bug or developer oversight?

ken edward
Hello,

How do you pass a command line parameter such as --enable-preview while
using JSVC?

jsvc -help  shows -X and -D but neither of these are appropriate for an
openjdk command line parameter like --enable-preview ?!?!?!?

    -D<name>=<value>
        set a Java system property
    -X<option>
        set Virtual Machine specific option

Ken
Reply | Threaded
Open this post in threaded view
|

Re: JSVC bug or developer oversight?

Bernd Eckenfels
Hello,

Seems not possible to pass options beside the known ones:

https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l425

One option is to pass all unknown options to java, another is to pass only the missing --enable-preview and lastly an repeatable option  --add-jvm-arg "--enable-preview". I think passing the options might be most flexible, but it needs to make sure to correctly detect spaces

--start --enable-preview -splash:"/Home/Insane User/foto.jpg"

Maybe adding the one missing option is fastest.

As a workaround, maybe you can use environment variable JDK_JAVA_OPTIONS?

Bernd
--
http://bernd.eckenfels.net
________________________________
Von: ken edward <[hidden email]>
Gesendet: Friday, March 20, 2020 9:12:57 PM
An: Commons Users List <[hidden email]>
Betreff: JSVC bug or developer oversight?

Hello,

How do you pass a command line parameter such as --enable-preview while
using JSVC?

jsvc -help  shows -X and -D but neither of these are appropriate for an
openjdk command line parameter like --enable-preview ?!?!?!?

    -D<name>=<value>
        set a Java system property
    -X<option>
        set Virtual Machine specific option

Ken
Reply | Threaded
Open this post in threaded view
|

Re: JSVC bug or developer oversight?

ken edward
I tried JDK_JAVA_OPTIONS and it does not seem to work either. I don't
suppose you could send me a source patch for the ability to pass the
--enable_preview parameter?

On Fri, Mar 20, 2020 at 10:57 PM Bernd Eckenfels <[hidden email]>
wrote:

> Hello,
>
> Seems not possible to pass options beside the known ones:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l425
>
> One option is to pass all unknown options to java, another is to pass only
> the missing --enable-preview and lastly an repeatable option  --add-jvm-arg
> "--enable-preview". I think passing the options might be most flexible, but
> it needs to make sure to correctly detect spaces
>
> --start --enable-preview -splash:"/Home/Insane User/foto.jpg"
>
> Maybe adding the one missing option is fastest.
>
> As a workaround, maybe you can use environment variable JDK_JAVA_OPTIONS?
>
> Bernd
> --
> http://bernd.eckenfels.net
> ________________________________
> Von: ken edward <[hidden email]>
> Gesendet: Friday, March 20, 2020 9:12:57 PM
> An: Commons Users List <[hidden email]>
> Betreff: JSVC bug or developer oversight?
>
> Hello,
>
> How do you pass a command line parameter such as --enable-preview while
> using JSVC?
>
> jsvc -help  shows -X and -D but neither of these are appropriate for an
> openjdk command line parameter like --enable-preview ?!?!?!?
>
>     -D<name>=<value>
>         set a Java system property
>     -X<option>
>         set Virtual Machine specific option
>
> Ken
>
Reply | Threaded
Open this post in threaded view
|

Re: JSVC bug or developer oversight?

Bernd Eckenfels
Helll,

I don't Have the built env here, but this should work, just duplicate any of the existing options:

378<https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l378> else if (!strcmp(argv[x], "-disablesystemassertions")) {
379<https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l379> args->opts[args->onum++] = strdup(argv[x]);
380<https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l380> }
else if (!strcmp(argv[x], "--enable-preview)) {
    args->opts[args->onum++] = strdup(argv[x]);
}



--
http://bernd.eckenfels.net
________________________________
Von: ken edward <[hidden email]>
Gesendet: Monday, March 23, 2020 6:05:44 PM
An: Commons Users List <[hidden email]>
Betreff: Re: JSVC bug or developer oversight?

I tried JDK_JAVA_OPTIONS and it does not seem to work either. I don't
suppose you could send me a source patch for the ability to pass the
--enable_preview parameter?

On Fri, Mar 20, 2020 at 10:57 PM Bernd Eckenfels <[hidden email]>
wrote:

> Hello,
>
> Seems not possible to pass options beside the known ones:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l425
>
> One option is to pass all unknown options to java, another is to pass only
> the missing --enable-preview and lastly an repeatable option  --add-jvm-arg
> "--enable-preview". I think passing the options might be most flexible, but
> it needs to make sure to correctly detect spaces
>
> --start --enable-preview -splash:"/Home/Insane User/foto.jpg"
>
> Maybe adding the one missing option is fastest.
>
> As a workaround, maybe you can use environment variable JDK_JAVA_OPTIONS?
>
> Bernd
> --
> http://bernd.eckenfels.net
> ________________________________
> Von: ken edward <[hidden email]>
> Gesendet: Friday, March 20, 2020 9:12:57 PM
> An: Commons Users List <[hidden email]>
> Betreff: JSVC bug or developer oversight?
>
> Hello,
>
> How do you pass a command line parameter such as --enable-preview while
> using JSVC?
>
> jsvc -help  shows -X and -D but neither of these are appropriate for an
> openjdk command line parameter like --enable-preview ?!?!?!?
>
>     -D<name>=<value>
>         set a Java system property
>     -X<option>
>         set Virtual Machine specific option
>
> Ken
>
Reply | Threaded
Open this post in threaded view
|

Re: JSVC bug or developer oversight?

ken edward
Thank you! that did in fact solve the issue!

On Mon, Mar 23, 2020 at 1:57 PM Bernd Eckenfels <[hidden email]>
wrote:

> Helll,
>
> I don't Have the built env here, but this should work, just duplicate any
> of the existing options:
>
> 378<
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l378>
> else if (!strcmp(argv[x], "-disablesystemassertions")) {
> 379<
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l379>
> args->opts[args->onum++] = strdup(argv[x]);
> 380<
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l380>
> }
> else if (!strcmp(argv[x], "--enable-preview)) {
>     args->opts[args->onum++] = strdup(argv[x]);
> }
>
>
>
> --
> http://bernd.eckenfels.net
> ________________________________
> Von: ken edward <[hidden email]>
> Gesendet: Monday, March 23, 2020 6:05:44 PM
> An: Commons Users List <[hidden email]>
> Betreff: Re: JSVC bug or developer oversight?
>
> I tried JDK_JAVA_OPTIONS and it does not seem to work either. I don't
> suppose you could send me a source patch for the ability to pass the
> --enable_preview parameter?
>
> On Fri, Mar 20, 2020 at 10:57 PM Bernd Eckenfels <[hidden email]>
> wrote:
>
> > Hello,
> >
> > Seems not possible to pass options beside the known ones:
> >
> >
> >
> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=blob;f=src/native/unix/native/arguments.c;h=8160c72944a7d7dae9cc8d43ec244f43a664a82f;hb=HEAD#l425
> >
> > One option is to pass all unknown options to java, another is to pass
> only
> > the missing --enable-preview and lastly an repeatable option
> --add-jvm-arg
> > "--enable-preview". I think passing the options might be most flexible,
> but
> > it needs to make sure to correctly detect spaces
> >
> > --start --enable-preview -splash:"/Home/Insane User/foto.jpg"
> >
> > Maybe adding the one missing option is fastest.
> >
> > As a workaround, maybe you can use environment variable JDK_JAVA_OPTIONS?
> >
> > Bernd
> > --
> > http://bernd.eckenfels.net
> > ________________________________
> > Von: ken edward <[hidden email]>
> > Gesendet: Friday, March 20, 2020 9:12:57 PM
> > An: Commons Users List <[hidden email]>
> > Betreff: JSVC bug or developer oversight?
> >
> > Hello,
> >
> > How do you pass a command line parameter such as --enable-preview while
> > using JSVC?
> >
> > jsvc -help  shows -X and -D but neither of these are appropriate for an
> > openjdk command line parameter like --enable-preview ?!?!?!?
> >
> >     -D<name>=<value>
> >         set a Java system property
> >     -X<option>
> >         set Virtual Machine specific option
> >
> > Ken
> >
>