[LANG] Github PR reviews

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[LANG] Github PR reviews

Otto Fowler
I see that github notices don’t get sent to this list, is there a procedure
to get a pr review?
Asking for a friend ;)

O
Reply | Threaded
Open this post in threaded view
|

Re: [LANG] Github PR reviews

garydgregory
We should get emails from GitHub... What is the link to your PR?

Gary

On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler <[hidden email]>
wrote:

> I see that github notices don’t get sent to this list, is there a procedure
> to get a pr review?
> Asking for a friend ;)
>
> O
>
Reply | Threaded
Open this post in threaded view
|

Re: [LANG] Github PR reviews

Otto Fowler
https://github.com/apache/commons-lang/pull/311

I did not see a mail for it.  If someone else *did* see it, then I am sorry.



On January 12, 2018 at 11:35:00, Gary Gregory ([hidden email])
wrote:

We should get emails from GitHub... What is the link to your PR?

Gary

On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler <[hidden email]>
wrote:

> I see that github notices don’t get sent to this list, is there a
procedure
> to get a pr review?
> Asking for a friend ;)
>
> O
>
Reply | Threaded
Open this post in threaded view
|

Re: [LANG] Github PR reviews

Stefan Bodewig
On 2018-01-12, Otto Fowler wrote:

> https://github.com/apache/commons-lang/pull/311

> I did not see a mail for it.  If someone else *did* see it, then I am sorry.

https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7dfc6b7874d1bea47c2ab4@%3Cissues.commons.apache.org%3E

By now we've got two different lists where notifications may end up, the
github notifications for lang go to issues@commons, those for compress
go to notifications@commons.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [LANG] Github PR reviews

garydgregory
In reply to this post by Otto Fowler
I am hoping to find time this weekend to review...

Gary

On Fri, Jan 12, 2018 at 9:40 AM, Otto Fowler <[hidden email]>
wrote:

> https://github.com/apache/commons-lang/pull/311
>
> I did not see a mail for it.  If someone else *did* see it, then I am
> sorry.
>
>
>
> On January 12, 2018 at 11:35:00, Gary Gregory ([hidden email])
> wrote:
>
> We should get emails from GitHub... What is the link to your PR?
>
> Gary
>
> On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler <[hidden email]>
> wrote:
>
> > I see that github notices don’t get sent to this list, is there a
> procedure
> > to get a pr review?
> > Asking for a friend ;)
> >
> > O
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [LANG] Github PR reviews

sebb-2-2
In reply to this post by Stefan Bodewig
On 12 January 2018 at 16:45, Stefan Bodewig <[hidden email]> wrote:

> On 2018-01-12, Otto Fowler wrote:
>
>> https://github.com/apache/commons-lang/pull/311
>
>> I did not see a mail for it.  If someone else *did* see it, then I am sorry.
>
> https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7dfc6b7874d1bea47c2ab4@%3Cissues.commons.apache.org%3E
>
> By now we've got two different lists where notifications may end up, the
> github notifications for lang go to issues@commons, those for compress
> go to notifications@commons.

That seems wrong.

IMO
issues should be for JIRA
notifications for commits, CI

> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Lists (was Re: [LANG] Github PR reviews)

Stefan Bodewig
On 2018-01-12, sebb wrote:

> On 12 January 2018 at 16:45, Stefan Bodewig <[hidden email]> wrote:

>> By now we've got two different lists where notifications may end up,
>> the github notifications for lang go to issues@commons, those for
>> compress go to notifications@commons.

> That seems wrong.

> IMO
> issues should be for JIRA
> notifications for commits, CI

Oh, we've also got commits@ which gets a bunch of svn commit messages as
well as messages for some (all?) of the git repos.  notifications seems
to be svn for most components and CI.

github integration looks very inconsistent. [lang] sends to issues,
[compress] to notifications and [collections] and [imaging] even to dev
- this is judging from the archive for the past few months.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Lists (was Re: [LANG] Github PR reviews)

sebb-2-2
On 12 January 2018 at 18:58, Stefan Bodewig <[hidden email]> wrote:

> On 2018-01-12, sebb wrote:
>
>> On 12 January 2018 at 16:45, Stefan Bodewig <[hidden email]> wrote:
>
>>> By now we've got two different lists where notifications may end up,
>>> the github notifications for lang go to issues@commons, those for
>>> compress go to notifications@commons.
>
>> That seems wrong.
>
>> IMO
>> issues should be for JIRA
>> notifications for commits, CI

Did I really write that? Oops...
Of course (most) commits should go to commits@

However website build commits go to notifications, as they are not as
important (the source changes should go to commits@)

> Oh, we've also got commits@ which gets a bunch of svn commit messages as
> well as messages for some (all?) of the git repos.  notifications seems
> to be svn for most components and CI.
>
> github integration looks very inconsistent. [lang] sends to issues,
> [compress] to notifications and [collections] and [imaging] even to dev
> - this is judging from the archive for the past few months.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]