[Math] About MATH-1329

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Math] About MATH-1329

Gilles Sadowski
Hi.

https://issues.apache.org/jira/browse/MATH-1329

Any idea why the "Entry" of a "RealVector" is "protected"?


Regards,
Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] About MATH-1329

Dave Brosius-2
Git blame says

git blame -L1028
src/main/java/org/apache/commons/math4/linear/RealVector.java
760078b4 src/main/java/org/apache/commons/math/linear/RealVector.java
(Gilles Sadowski   2011-08-28 12:58:57 +0000 1028)     protected class
Entry {

Was like that from the first time it was added.

So i suppose you have yourself to blame ;)

On 02/28/2016 08:10 PM, Gilles wrote:

> Hi.
>
> https://issues.apache.org/jira/browse/MATH-1329
>
> Any idea why the "Entry" of a "RealVector" is "protected"?
>
>
> Regards,
> Gilles
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [Math] About MATH-1329

Gilles Sadowski
Hi.

On Sun, 28 Feb 2016 21:59:11 -0500, Dave Brosius wrote:

> Git blame says
>
> git blame -L1028
> src/main/java/org/apache/commons/math4/linear/RealVector.java
> 760078b4 src/main/java/org/apache/commons/math/linear/RealVector.java
> (Gilles Sadowski   2011-08-28 12:58:57 +0000 1028)     protected
> class
> Entry {
>
> Was like that from the first time it was added.

It was a class rename; code existed before:

 
https://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/AbstractRealVector.java?view=log&pathrev=889008

> So i suppose you have yourself to blame ;)

  https://issues.apache.org/jira/browse/MATH-765
  https://issues.apache.org/jira/browse/MATH-766

Problems (as a consequence of code bloat[1]) were identified a long
time ago.  A major overhaul was suggested...


Regards,
Gilles

[1] This is the situation we arrive at when evolution is by default
     considered as a liability rather than an opportunity to revisit
     the codebase, and perform a sometimes long overdue cleanup.

> On 02/28/2016 08:10 PM, Gilles wrote:
>> Hi.
>>
>> https://issues.apache.org/jira/browse/MATH-1329
>>
>> Any idea why the "Entry" of a "RealVector" is "protected"?
>>
>>
>> Regards,
>> Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]